| Message ID | 2de75a74ef4086090c532d3b80b7d6dcd115e45e.1569410216.git.shubhrajyoti.datta@xilinx.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [RFC,1/2] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Wed, Sep 25, 2019 at 04:53:07PM +0530, Shubhrajyoti Datta wrote: > Add support for the FlexNoc Performance Monitor. > Adds support for various port setting and monitoring > the packets transactions. It supports LPD and FPD monitoring > counters for read and write transaction requests and responses. > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > drivers/misc/Kconfig | 9 + > drivers/misc/Makefile | 1 + > drivers/misc/xilinx_flex_pm.c | 644 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 654 insertions(+) > create mode 100644 drivers/misc/xilinx_flex_pm.c You are creating new sysfs files (in a buggy and racy way), and not documenting them in Documentation/ABI/ which is not allowed. Please fix up both issues before resending. thanks, greg k-h
diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt new file mode 100644 index 0000000..6b533bc --- /dev/null +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt @@ -0,0 +1,24 @@ +* Xilinx Flexnoc Performance Monitor driver + +The FlexNoc Performance Monitor has counters for monitoring +the read and the write transaction counter. + +Required properties: +- compatible: "xlnx,flexnoc-pm-2.7" +- reg : Address and length of register sets for each device in + "reg-names" +- reg-names : The names of the register addresses corresponding to the + registers filled in "reg" + - funnel: base address of the funnel registers + - baselpd: base address of the LPD PM registers + - basefpd: base address FPD PM registers + +Example: +++++++++ +performance-monitor@f0920000 { + compatible = "xlnx,flexnoc-pm-2.7"; + reg-names = "funnel", "baselpd", "basefpd"; + reg = <0x0 0xf0920000 0x0 0x1000>, + <0x0 0xf0980000 0x0 0x9000>, + <0x0 0xf0b80000 0x0 0x9000>; +};
Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt -- 2.1.1 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.