| Message ID | 20251028-add-support-for-camss-on-kaanapali-v4-1-7eb484c89585@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: qcom: camss: Add Kaanapali support | expand |
On Tue, Oct 28, 2025 at 10:44:10PM -0700, Hangxiang Ma wrote: > Add Kaanapali compatible consistent with CAMSS CCI interfaces. > You are using b4 so I don't understand why you still ignore our review. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
Hi, On Tue, Oct 28, 2025 at 10:44:10PM -0700, Hangxiang Ma wrote: > Add Kaanapali compatible consistent with CAMSS CCI interfaces. > > Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> Patch 1/6 applied to i2c/i2c-host. b4 added automatically Loic's and Krzysztof's r-b. Please, next time don't forget to add the reviews you got. It's also useful for the maintainer not to dig the mail history to figure out the tags you received. Thanks, Andi
On 10/30/2025 3:12 PM, Krzysztof Kozlowski wrote: > On Tue, Oct 28, 2025 at 10:44:10PM -0700, Hangxiang Ma wrote: >> Add Kaanapali compatible consistent with CAMSS CCI interfaces. >> > > You are using b4 so I don't understand why you still ignore our review. > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions of patchset, under or above your Signed-off-by tag, unless > patch changed significantly (e.g. new properties added to the DT > bindings). Tag is "received", when provided in a message replied to you > on the mailing list. Tools like b4 can help here. However, there's no > need to repost patches *only* to add the tags. The upstream maintainer > will do that for tags received on the version they apply. > > Please read: > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > On 10/30/2025 8:30 PM, Andi Shyti wrote:> Hi, > > On Tue, Oct 28, 2025 at 10:44:10PM -0700, Hangxiang Ma wrote: >> Add Kaanapali compatible consistent with CAMSS CCI interfaces. >> >> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> > > Patch 1/6 applied to i2c/i2c-host. > > b4 added automatically Loic's and Krzysztof's r-b. Please, next > time don't forget to add the reviews you got. It's also useful > for the maintainer not to dig the mail history to figure out the > tags you received. > > Thanks, > Andi Thanks Krzysztof, Andi. Will add these tags by b4 tool in next revision. --- Hangxiang
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index 9bc99d736343..9b83ec63e124 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -25,6 +25,7 @@ properties: - items: - enum: + - qcom,kaanapali-cci - qcom,qcm2290-cci - qcom,sa8775p-cci - qcom,sc7280-cci @@ -128,6 +129,7 @@ allOf: compatible: contains: enum: + - qcom,kaanapali-cci - qcom,qcm2290-cci then: properties:
Add Kaanapali compatible consistent with CAMSS CCI interfaces. Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com> --- Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++ 1 file changed, 2 insertions(+)