| Message ID | 20251023080609.1212-5-yuanjie.yang@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm: Add support for Kaanapali | expand |
On Thu, Oct 23, 2025 at 04:06:07PM +0800, yuanjie yang wrote: > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> In the subject: DSI, not DSi > > Add DSI PHY for Kaanapali. Why? > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index 1ca820a500b7..a6e044eed3df 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -17,6 +17,7 @@ properties: > enum: > - qcom,dsi-phy-7nm > - qcom,dsi-phy-7nm-8150 > + - qcom,kaanapali-dsi-phy-3nm > - qcom,sa8775p-dsi-phy-5nm > - qcom,sar2130p-dsi-phy-5nm > - qcom,sc7280-dsi-phy-7nm > -- > 2.34.1 >
On Thu, Oct 23, 2025 at 03:16:31PM +0300, Dmitry Baryshkov wrote: > On Thu, Oct 23, 2025 at 04:06:07PM +0800, yuanjie yang wrote: > > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> > > In the subject: DSI, not DSi OK will note. > > > > Add DSI PHY for Kaanapali. > > Why? DSI phy for Kaanapali have no significant diiference with previous version(SM8750). But some register change make it imcompatible with previous version(SM8750). I will give this reason in my next patch. Thanks Yuanjie. > > > > > Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> > > Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> > > --- > > Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > index 1ca820a500b7..a6e044eed3df 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > > @@ -17,6 +17,7 @@ properties: > > enum: > > - qcom,dsi-phy-7nm > > - qcom,dsi-phy-7nm-8150 > > + - qcom,kaanapali-dsi-phy-3nm > > - qcom,sa8775p-dsi-phy-5nm > > - qcom,sar2130p-dsi-phy-5nm > > - qcom,sc7280-dsi-phy-7nm > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry
On Fri, Oct 24, 2025 at 02:10:29PM +0800, yuanjiey wrote: > On Thu, Oct 23, 2025 at 03:16:31PM +0300, Dmitry Baryshkov wrote: > > On Thu, Oct 23, 2025 at 04:06:07PM +0800, yuanjie yang wrote: > > > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> > > > > In the subject: DSI, not DSi > OK will note. > > > > > > > > Add DSI PHY for Kaanapali. > > > > Why? > > DSI phy for Kaanapali have no significant diiference with previous version(SM8750). > But some register change make it imcompatible with previous version(SM8750). It's either "no significant difference" or "register change make it incompatible". You can't say both. > > I will give this reason in my next patch. > > Thanks > Yuanjie. >
On Mon, Oct 27, 2025 at 03:30:43PM +0200, Dmitry Baryshkov wrote: > On Fri, Oct 24, 2025 at 02:10:29PM +0800, yuanjiey wrote: > > On Thu, Oct 23, 2025 at 03:16:31PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Oct 23, 2025 at 04:06:07PM +0800, yuanjie yang wrote: > > > > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com> > > > > > > In the subject: DSI, not DSi > > OK will note. > > > > > > > > > > > > Add DSI PHY for Kaanapali. > > > > > > Why? > > > > DSI phy for Kaanapali have no significant diiference with previous version(SM8750). > > But some register change make it imcompatible with previous version(SM8750). > > It's either "no significant difference" or "register change make it > incompatible". You can't say both. Sure, will optimize commit message. Thanks, Yuanjie > > > > I will give this reason in my next patch. > > > > Thanks > > Yuanjie. > > > > -- > With best wishes > Dmitry
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml index 1ca820a500b7..a6e044eed3df 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml @@ -17,6 +17,7 @@ properties: enum: - qcom,dsi-phy-7nm - qcom,dsi-phy-7nm-8150 + - qcom,kaanapali-dsi-phy-3nm - qcom,sa8775p-dsi-phy-5nm - qcom,sar2130p-dsi-phy-5nm - qcom,sc7280-dsi-phy-7nm