diff mbox series

[RFC,1/3] ASoC: dt-bindings: qcom,sm8250: Add Dell XPS13 9345 sound card

Message ID 20251021-dell-xps13-9345-enable-audio-v1-1-6f3f6bbd977b@linaro.org
State New
Headers show
Series ASoC: qcom: x1e80100: Add sound card support for Dell XPS13 9345 | expand

Commit Message

Abel Vesa Oct. 21, 2025, 1:50 p.m. UTC
The Dell XPS13 9345 maps the speakers and tweeters starting from
the right side instead of left, which means we need to handle it
differently then the rest of the X Elite platforms.

So document its new compatible.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Oct. 22, 2025, 10:56 a.m. UTC | #1
On 21/10/2025 15:50, Abel Vesa wrote:
> The Dell XPS13 9345 maps the speakers and tweeters starting from
> the right side instead of left, which means we need to handle it
> differently then the rest of the X Elite platforms.
> 
> So document its new compatible.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index 868acc077046596120ea7f427e802282ed03c853..20566224d2e42574ab96f93c11924bbeae22f0bc 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -29,6 +29,7 @@ properties:
>                - qcom,sm8750-sndcard
>            - const: qcom,sm8450-sndcard
>        - enum:
> +          - dell,xps13-9345-sndcard

When I explained you how to proceed, I said - you need front compatible,
because this sound card is compatible with existing one, with a quirk
needed.

Might not matter if we go with mixers solution as suggested by Srini.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 868acc077046596120ea7f427e802282ed03c853..20566224d2e42574ab96f93c11924bbeae22f0bc 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -29,6 +29,7 @@  properties:
               - qcom,sm8750-sndcard
           - const: qcom,sm8450-sndcard
       - enum:
+          - dell,xps13-9345-sndcard
           - fairphone,fp4-sndcard
           - fairphone,fp5-sndcard
           - qcom,apq8096-sndcard