| Message ID | 20251018093229.291419-1-olek2@wp.pl |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: watchdog: lantiq,wdt: convert bindings to dtschema | expand |
On 18/10/2025 11:29, Aleksander Jan Bajkowski wrote: > Convert the Lantiq WDT Watchdog bindings to yaml format. > > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> > --- > v2: > - requirement of lantiq,rcu is now expressed as a schema > --- > .../bindings/watchdog/lantiq,wdt.yaml | 63 +++++++++++++++++++ > .../bindings/watchdog/lantiq-wdt.txt | 24 ------- > 2 files changed, 63 insertions(+), 24 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > delete mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > new file mode 100644 > index 000000000000..204e16be2a79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/lantiq,wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Lantiq WTD watchdog > + > +maintainers: > + - Hauke Mehrtens <hauke@hauke-m.de> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - lantiq,falcon-wdt > + - lantiq,wdt > + - lantiq,xrx100-wdt > + - items: > + - enum: > + - lantiq,xrx200-wdt > + - lantiq,xrx300-wdt This wasn't in the old binding. Any change from pure conversion has to be explained WHY in the commit msg. What is more - it does not exist. You cannot just stuff here new compatibles and call it "conversion". Conversion from dev/null into new compatible? > + - const: lantiq,xrx100-wdt > + > + reg: > + maxItems: 1 > + > + lantiq,rcu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Phandle to the RCU syscon node > + > +required: > + - compatible > + - reg > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: lantiq,xrx100-wdt > + then: > + required: > + - lantiq,rcu > + - if: > + properties: > + compatible: > + contains: > + const: lantiq,falcon-wdt That's just enum in previous contains. > + then: > + required: > + - lantiq,rcu Missing ref to watchdog. Otherwise why do you have unevaluatedProperties? > + > +unevaluatedProperties: false Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml new file mode 100644 index 000000000000..204e16be2a79 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/lantiq,wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq WTD watchdog + +maintainers: + - Hauke Mehrtens <hauke@hauke-m.de> + +properties: + compatible: + oneOf: + - enum: + - lantiq,falcon-wdt + - lantiq,wdt + - lantiq,xrx100-wdt + - items: + - enum: + - lantiq,xrx200-wdt + - lantiq,xrx300-wdt + - const: lantiq,xrx100-wdt + + reg: + maxItems: 1 + + lantiq,rcu: + $ref: /schemas/types.yaml#/definitions/phandle + description: Phandle to the RCU syscon node + +required: + - compatible + - reg + +allOf: + - if: + properties: + compatible: + contains: + const: lantiq,xrx100-wdt + then: + required: + - lantiq,rcu + - if: + properties: + compatible: + contains: + const: lantiq,falcon-wdt + then: + required: + - lantiq,rcu + +unevaluatedProperties: false + +examples: + - | + watchdog@803f0 { + compatible = "lantiq,xrx200-wdt", "lantiq,xrx100-wdt"; + reg = <0x803f0 0x10>; + + lantiq,rcu = <&rcu0>; + }; diff --git a/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt b/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt deleted file mode 100644 index 18d4d8302702..000000000000 --- a/Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt +++ /dev/null @@ -1,24 +0,0 @@ -Lantiq WTD watchdog binding -============================ - -This describes the binding of the Lantiq watchdog driver. - -------------------------------------------------------------------------------- -Required properties: -- compatible : Should be one of - "lantiq,wdt" - "lantiq,xrx100-wdt" - "lantiq,xrx200-wdt", "lantiq,xrx100-wdt" - "lantiq,falcon-wdt" -- reg : Address of the watchdog block -- lantiq,rcu : A phandle to the RCU syscon (required for - "lantiq,falcon-wdt" and "lantiq,xrx100-wdt") - -------------------------------------------------------------------------------- -Example for the watchdog on the xRX200 SoCs: - watchdog@803f0 { - compatible = "lantiq,xrx200-wdt", "lantiq,xrx100-wdt"; - reg = <0x803f0 0x10>; - - lantiq,rcu = <&rcu0>; - };
Convert the Lantiq WDT Watchdog bindings to yaml format. Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl> --- v2: - requirement of lantiq,rcu is now expressed as a schema --- .../bindings/watchdog/lantiq,wdt.yaml | 63 +++++++++++++++++++ .../bindings/watchdog/lantiq-wdt.txt | 24 ------- 2 files changed, 63 insertions(+), 24 deletions(-) create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml delete mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt