| Message ID | 20250608235840.23871-6-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | media: imx-mipi-csis: Cleanups and debugging improvements | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | success |
On Mon, Jun 09, 2025 at 02:58:37AM +0300, Laurent Pinchart wrote: > Usage of the clock-frequency property, which is already optional, is > discouraged in favour of using assigned-clock-rates (and > assigned-clock-parents where needed). Mark the property as deprecated, > and update the examples accordingly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > .../devicetree/bindings/media/nxp,imx-mipi-csi2.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > index 03a23a26c4f3..db4889bf881e 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > @@ -66,6 +66,7 @@ properties: > clock-frequency: > description: The desired external clock ("wrap") frequency, in Hz > default: 166000000 > + deprecated: true > > ports: > $ref: /schemas/graph.yaml#/properties/ports > @@ -147,7 +148,9 @@ examples: > <&clks IMX7D_MIPI_CSI_ROOT_CLK>, > <&clks IMX7D_MIPI_DPHY_ROOT_CLK>; > clock-names = "pclk", "wrap", "phy"; > - clock-frequency = <166000000>; > + > + assigned-clocks = <&clks IMX7D_MIPI_CSI_ROOT_CLK>; > + assigned-clock-rates = <166000000>; > > power-domains = <&pgc_mipi_phy>; > phy-supply = <®_1p0d>; > @@ -185,12 +188,16 @@ examples: > compatible = "fsl,imx8mm-mipi-csi2"; > reg = <0x32e30000 0x1000>; > interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>; > - clock-frequency = <333000000>; > + > clocks = <&clk IMX8MM_CLK_DISP_APB_ROOT>, > <&clk IMX8MM_CLK_CSI1_ROOT>, > <&clk IMX8MM_CLK_CSI1_PHY_REF>, > <&clk IMX8MM_CLK_DISP_AXI_ROOT>; > clock-names = "pclk", "wrap", "phy", "axi"; > + > + assigned-clocks = <&clk IMX8MM_CLK_CSI1_ROOT>; > + assigned-clock-rates = <250000000>; > + > power-domains = <&mipi_pd>; > > ports { > -- > Regards, > > Laurent Pinchart >
On Mon, 09 Jun 2025 02:58:37 +0300, Laurent Pinchart wrote: > Usage of the clock-frequency property, which is already optional, is > discouraged in favour of using assigned-clock-rates (and > assigned-clock-parents where needed). Mark the property as deprecated, > and update the examples accordingly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../devicetree/bindings/media/nxp,imx-mipi-csi2.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml index 03a23a26c4f3..db4889bf881e 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml @@ -66,6 +66,7 @@ properties: clock-frequency: description: The desired external clock ("wrap") frequency, in Hz default: 166000000 + deprecated: true ports: $ref: /schemas/graph.yaml#/properties/ports @@ -147,7 +148,9 @@ examples: <&clks IMX7D_MIPI_CSI_ROOT_CLK>, <&clks IMX7D_MIPI_DPHY_ROOT_CLK>; clock-names = "pclk", "wrap", "phy"; - clock-frequency = <166000000>; + + assigned-clocks = <&clks IMX7D_MIPI_CSI_ROOT_CLK>; + assigned-clock-rates = <166000000>; power-domains = <&pgc_mipi_phy>; phy-supply = <®_1p0d>; @@ -185,12 +188,16 @@ examples: compatible = "fsl,imx8mm-mipi-csi2"; reg = <0x32e30000 0x1000>; interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>; - clock-frequency = <333000000>; + clocks = <&clk IMX8MM_CLK_DISP_APB_ROOT>, <&clk IMX8MM_CLK_CSI1_ROOT>, <&clk IMX8MM_CLK_CSI1_PHY_REF>, <&clk IMX8MM_CLK_DISP_AXI_ROOT>; clock-names = "pclk", "wrap", "phy", "axi"; + + assigned-clocks = <&clk IMX8MM_CLK_CSI1_ROOT>; + assigned-clock-rates = <250000000>; + power-domains = <&mipi_pd>; ports {
Usage of the clock-frequency property, which is already optional, is discouraged in favour of using assigned-clock-rates (and assigned-clock-parents where needed). Mark the property as deprecated, and update the examples accordingly. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../devicetree/bindings/media/nxp,imx-mipi-csi2.yaml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)