| Message ID | 20250603-dt-bindings-mailbox-cleanup-v1-5-724407563997@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: mailbox: Few cleanups | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | success |
On 13:57-20250603, Krzysztof Kozlowski wrote: > Providers DTS examples should not contain consumer nodes, because they > are completely redundant, obvious (defined in common schema) and add > unnecessary bloat. Drop consumer examples and unneeded node labels. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- [...] > diff --git a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > index 1a2001e58880d2fc26954b26cff8ed53e7667f33..8504ceb64806bc7e25468597acdff99624571e9f 100644 > --- a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > @@ -242,7 +242,7 @@ examples: > - | > /* OMAP4 */ > #include <dt-bindings/interrupt-controller/arm-gic.h> > - mailbox: mailbox@4a0f4000 { > + mailbox@4a0f4000 { > compatible = "ti,omap4-mailbox"; > reg = <0x4a0f4000 0x200>; > interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>; > @@ -260,13 +260,9 @@ examples: > }; > }; > > - dsp { > - mboxes = <&mailbox &mbox_dsp>; > - }; > - > - | > /* AM33xx */ > - mailbox1: mailbox@480c8000 { > + mailbox@480c8000 { > compatible = "ti,omap4-mailbox"; > reg = <0x480c8000 0x200>; > interrupts = <77>; > @@ -283,7 +279,7 @@ examples: > > - | > /* AM65x */ > - mailbox0_cluster0: mailbox@31f80000 { > + mailbox@31f80000 { > compatible = "ti,am654-mailbox"; > reg = <0x31f80000 0x200>; > #mbox-cells = <1>; > Reviewed-by: Nishanth Menon <nm@ti.com> > -- > 2.45.2 >
On Tue, 03 Jun 2025 13:57:12 +0200, Krzysztof Kozlowski wrote: > Providers DTS examples should not contain consumer nodes, because they > are completely redundant, obvious (defined in common schema) and add > unnecessary bloat. Drop consumer examples and unneeded node labels. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml | 6 +----- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 9 +-------- > Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml | 10 +++------- > 3 files changed, 5 insertions(+), 20 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml b/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml index e1a44e4ae6f91eaa1cd81b357e9e5caeaaf0f5bb..3a387d5e4f065e6fe1bed7e402cb236f4e13ef56 100644 --- a/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml +++ b/Documentation/devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml @@ -108,14 +108,10 @@ examples: #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/mailbox/tegra186-hsp.h> - hsp_top0: mailbox@3c00000 { + mailbox@3c00000 { compatible = "nvidia,tegra186-hsp"; reg = <0x03c00000 0xa0000>; interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "doorbell"; #mbox-cells = <2>; }; - - client { - mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_DB TEGRA_HSP_DB_MASTER_CCPLEX>; - }; diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index a58a018f3f7b9f8edd70d7c1bd137844ff2549df..ae28ba44855f75e83ea70ce3c670465ae145178e 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -200,7 +200,7 @@ examples: # Example apcs with msm8996 - | #include <dt-bindings/interrupt-controller/arm-gic.h> - apcs_glb: mailbox@9820000 { + mailbox@9820000 { compatible = "qcom,msm8996-apcs-hmss-global"; reg = <0x9820000 0x1000>; @@ -208,13 +208,6 @@ examples: #clock-cells = <0>; }; - rpm-glink { - compatible = "qcom,glink-rpm"; - interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>; - qcom,rpm-msg-ram = <&rpm_msg_ram>; - mboxes = <&apcs_glb 0>; - }; - # Example apcs with qcs404 - | #define GCC_APSS_AHB_CLK_SRC 1 diff --git a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml index 1a2001e58880d2fc26954b26cff8ed53e7667f33..8504ceb64806bc7e25468597acdff99624571e9f 100644 --- a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml @@ -242,7 +242,7 @@ examples: - | /* OMAP4 */ #include <dt-bindings/interrupt-controller/arm-gic.h> - mailbox: mailbox@4a0f4000 { + mailbox@4a0f4000 { compatible = "ti,omap4-mailbox"; reg = <0x4a0f4000 0x200>; interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>; @@ -260,13 +260,9 @@ examples: }; }; - dsp { - mboxes = <&mailbox &mbox_dsp>; - }; - - | /* AM33xx */ - mailbox1: mailbox@480c8000 { + mailbox@480c8000 { compatible = "ti,omap4-mailbox"; reg = <0x480c8000 0x200>; interrupts = <77>; @@ -283,7 +279,7 @@ examples: - | /* AM65x */ - mailbox0_cluster0: mailbox@31f80000 { + mailbox@31f80000 { compatible = "ti,am654-mailbox"; reg = <0x31f80000 0x200>; #mbox-cells = <1>;
Providers DTS examples should not contain consumer nodes, because they are completely redundant, obvious (defined in common schema) and add unnecessary bloat. Drop consumer examples and unneeded node labels. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/mailbox/nvidia,tegra186-hsp.yaml | 6 +----- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 9 +-------- Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml | 10 +++------- 3 files changed, 5 insertions(+), 20 deletions(-)