| Message ID | 20250519160448.209461-2-18255117159@163.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Relax max-link-speed check to support PCIe Gen5/Gen6 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On Tue, May 20, 2025 at 12:04:46AM +0800, Hans Zhang wrote: > Update the device tree binding documentation for PCI to include > PCIe Gen5 and Gen6 support in the `max-link-speed` property. > The original documentation limited the value to 1~4 (Gen1~Gen4), > but the kernel now supports up to Gen6. This change ensures the > documentation aligns with the actual code implementation. > > Signed-off-by: Hans Zhang <18255117159@163.com> > --- > Documentation/devicetree/bindings/pci/pci.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) This file is now removed. Update the schema if you need to. It lives in dtschema project. > > diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt > index 6a8f2874a24d..5ffd690e3fc7 100644 > --- a/Documentation/devicetree/bindings/pci/pci.txt > +++ b/Documentation/devicetree/bindings/pci/pci.txt > @@ -22,8 +22,9 @@ driver implementation may support the following properties: > If present this property specifies PCI gen for link capability. Host > drivers could add this as a strategy to avoid unnecessary operation for > unsupported link speed, for instance, trying to do training for > - unsupported link speed, etc. Must be '4' for gen4, '3' for gen3, '2' > - for gen2, and '1' for gen1. Any other values are invalid. > + unsupported link speed, etc. Must be '6' for gen6, '5' for gen5, '4' for > + gen4, '3' for gen3, '2' for gen2, and '1' for gen1. Any other values are > + invalid. > - reset-gpios: > If present this property specifies PERST# GPIO. Host drivers can parse the > GPIO and apply fundamental reset to endpoints. > -- > 2.25.1 >
On 2025/5/28 03:35, Rob Herring wrote: > On Tue, May 20, 2025 at 12:04:46AM +0800, Hans Zhang wrote: >> Update the device tree binding documentation for PCI to include >> PCIe Gen5 and Gen6 support in the `max-link-speed` property. >> The original documentation limited the value to 1~4 (Gen1~Gen4), >> but the kernel now supports up to Gen6. This change ensures the >> documentation aligns with the actual code implementation. >> >> Signed-off-by: Hans Zhang <18255117159@163.com> >> --- >> Documentation/devicetree/bindings/pci/pci.txt | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > This file is now removed. Update the schema if you need to. It lives in > dtschema project. > Dear Rob, Thank you very much for your reply and reminder. I will resubmit in the next version. Best regards, Hans >> >> diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt >> index 6a8f2874a24d..5ffd690e3fc7 100644 >> --- a/Documentation/devicetree/bindings/pci/pci.txt >> +++ b/Documentation/devicetree/bindings/pci/pci.txt >> @@ -22,8 +22,9 @@ driver implementation may support the following properties: >> If present this property specifies PCI gen for link capability. Host >> drivers could add this as a strategy to avoid unnecessary operation for >> unsupported link speed, for instance, trying to do training for >> - unsupported link speed, etc. Must be '4' for gen4, '3' for gen3, '2' >> - for gen2, and '1' for gen1. Any other values are invalid. >> + unsupported link speed, etc. Must be '6' for gen6, '5' for gen5, '4' for >> + gen4, '3' for gen3, '2' for gen2, and '1' for gen1. Any other values are >> + invalid. >> - reset-gpios: >> If present this property specifies PERST# GPIO. Host drivers can parse the >> GPIO and apply fundamental reset to endpoints. >> -- >> 2.25.1 >>
diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt index 6a8f2874a24d..5ffd690e3fc7 100644 --- a/Documentation/devicetree/bindings/pci/pci.txt +++ b/Documentation/devicetree/bindings/pci/pci.txt @@ -22,8 +22,9 @@ driver implementation may support the following properties: If present this property specifies PCI gen for link capability. Host drivers could add this as a strategy to avoid unnecessary operation for unsupported link speed, for instance, trying to do training for - unsupported link speed, etc. Must be '4' for gen4, '3' for gen3, '2' - for gen2, and '1' for gen1. Any other values are invalid. + unsupported link speed, etc. Must be '6' for gen6, '5' for gen5, '4' for + gen4, '3' for gen3, '2' for gen2, and '1' for gen1. Any other values are + invalid. - reset-gpios: If present this property specifies PERST# GPIO. Host drivers can parse the GPIO and apply fundamental reset to endpoints.
Update the device tree binding documentation for PCI to include PCIe Gen5 and Gen6 support in the `max-link-speed` property. The original documentation limited the value to 1~4 (Gen1~Gen4), but the kernel now supports up to Gen6. This change ensures the documentation aligns with the actual code implementation. Signed-off-by: Hans Zhang <18255117159@163.com> --- Documentation/devicetree/bindings/pci/pci.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)