| Message ID | 20250518220707.669515-7-jonas@kwiboo.se |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | rockchip: Add power controller support for RK3528 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | success |
On Sun, May 18, 2025 at 10:06:53PM +0000, Jonas Karlman wrote: > The GPIO controllers in most Rockchip SoCs are part or power domains > that are always powered on, i.e. PD_BUS or PD_PMU. Are these described in DT, so this is valid to add for all SoCs? > On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO > and PD_VPU power domains. So should be required for RK3528? > > Add support to describe power-domains for the GPIO controllers. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> > --- > Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index d76987ce8e50..bdd83f42615c 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -41,6 +41,9 @@ properties: > "#interrupt-cells": > const: 2 > > + power-domains: > + maxItems: 1 > + > patternProperties: > "^.+-hog(-[0-9]+)?$": > type: object > -- > 2.49.0 >
Hi Rob, On 2025-05-27 21:34, Rob Herring wrote: > On Sun, May 18, 2025 at 10:06:53PM +0000, Jonas Karlman wrote: >> The GPIO controllers in most Rockchip SoCs are part or power domains >> that are always powered on, i.e. PD_BUS or PD_PMU. > > Are these described in DT, so this is valid to add for all SoCs? PD_BUS and PD_PMU for prior generation Rockchip SoCs has typically not been fully described in device tree. Probably because they always needs to be powered on or missing documentation. > >> On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO >> and PD_VPU power domains. > > So should be required for RK3528? One of the five GPIO controllers on RK3528 is part of a power domain not being described in the device tree. And without having access to any TRM or other documentation it probably wont be. So requiring for RK3528 is not fully possible, and for GPIO controllers in other Rockchip SoCs the power-domain could theoretically be described in device tree. Regards, Jonas > >> >> Add support to describe power-domains for the GPIO controllers. >> >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se> >> --- >> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml >> index d76987ce8e50..bdd83f42615c 100644 >> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml >> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml >> @@ -41,6 +41,9 @@ properties: >> "#interrupt-cells": >> const: 2 >> >> + power-domains: >> + maxItems: 1 >> + >> patternProperties: >> "^.+-hog(-[0-9]+)?$": >> type: object >> -- >> 2.49.0 >>
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml index d76987ce8e50..bdd83f42615c 100644 --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml @@ -41,6 +41,9 @@ properties: "#interrupt-cells": const: 2 + power-domains: + maxItems: 1 + patternProperties: "^.+-hog(-[0-9]+)?$": type: object
The GPIO controllers in most Rockchip SoCs are part or power domains that are always powered on, i.e. PD_BUS or PD_PMU. On RK3528 the GPIO controllers are spread out among the PD_RKVENC, PD_VO and PD_VPU power domains. Add support to describe power-domains for the GPIO controllers. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 3 +++ 1 file changed, 3 insertions(+)