diff mbox series

[1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios" binding

Message ID 20250514-ubx-safeboot-v1-1-1ae771335356@geotab.com
State Changes Requested
Headers show
Series Add support for safeboot pin to UBlox GNSS driver | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dt-meta-schema success

Commit Message

Alejandro Enrique via B4 Relay May 14, 2025, 1:54 p.m. UTC 
From: Alejandro Enrique <alejandroe1@geotab.com>

U-Blox M8/M9 chip have a pin to start it in safeboot mode, to be used
to recover from situations where the flash content has become
corrupted and needs to be restored. Introduce a binding to support
this safeboot pin.

Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
---
 Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski May 21, 2025, 9:27 a.m. UTC | #1 
On Wed, May 14, 2025 at 03:54:41PM GMT, Alejandro Enrique wrote:
> U-Blox M8/M9 chip have a pin to start it in safeboot mode, to be used
> to recover from situations where the flash content has become
> corrupted and needs to be restored. Introduce a binding to support
> this safeboot pin.
> 
> Signed-off-by: Alejandro Enrique <alejandroe1@geotab.com>
> ---
>  Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..16d922279def99257c194520a7ac820f2a26e9c7 100644
> --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
> @@ -32,6 +32,9 @@ properties:
>    reset-gpios:
>      maxItems: 1
>  
> +  safeboot-gpios:
> +    maxItems: 1
> +

You need if:then: disallowing (:false) this for 6m and 8. Move entire allOf down
and add there new if: clause. (see example schema)

>    vcc-supply:
>      description: >
>        Main voltage regulator
> @@ -61,5 +64,6 @@ examples:
>              v-bckp-supply = <&gnss_v_bckp_reg>;
>              vcc-supply = <&gnss_vcc_reg>;
>              reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> +            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;

Thats 8, not 8m?

Best regards,
Krzysztof
Alejandro Enrique May 22, 2025, 4:32 p.m. UTC | #2 
On Wed, May 21, 2025 at 11:27 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> You need if:then: disallowing (:false) this for 6m and 8. Move entire allOf down
> and add there new if: clause. (see example schema)

I see, I will add that.
>
> >    vcc-supply:
> >      description: >
> >        Main voltage regulator
> > @@ -61,5 +64,6 @@ examples:
> >              v-bckp-supply = <&gnss_v_bckp_reg>;
> >              vcc-supply = <&gnss_vcc_reg>;
> >              reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> > +            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>
> Thats 8, not 8m?
My bad. Anyway I now checked the integration manual and it seems the
neo-8 also supports it. So I will send a version 2 of the patch
disallowing safeboot-gpios just for the neo-6m.
Thanks for the review..
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
index 7d4b6d49e5eea2201ac05ba6d54b1c1721172f26..16d922279def99257c194520a7ac820f2a26e9c7 100644
--- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
+++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml
@@ -32,6 +32,9 @@  properties:
   reset-gpios:
     maxItems: 1
 
+  safeboot-gpios:
+    maxItems: 1
+
   vcc-supply:
     description: >
       Main voltage regulator
@@ -61,5 +64,6 @@  examples:
             v-bckp-supply = <&gnss_v_bckp_reg>;
             vcc-supply = <&gnss_vcc_reg>;
             reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
+            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
         };
     };