| Message ID | 20250513215934.933807-3-jm@ti.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce PRU UART driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | success |
On 13/05/2025 23:59, Judith Mendez wrote: > Add documentation for PRU UART node which is for PRU serial UART > based-off the industry standard TL16C550 asynchronous communications > element. > > Signed-off-by: Judith Mendez <jm@ti.com> > --- > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Nothing in cover letter explains dependency and this the most important part of cover letter. Otherwise how maintainers are supposed to guess what they can take and what cannot? Squash the patch with previous in such case. > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > index 927b3200e29e..54397297cbf5 100644 > --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > @@ -324,6 +324,13 @@ patternProperties: > $ref: /schemas/net/ti,davinci-mdio.yaml# > type: object > > + serial@[a-f0-9]+$: > + description: | Do not need '|' unless you need to preserve formatting. Best regards, Krzysztof
On 5/14/25 7:35 AM, Krzysztof Kozlowski wrote: > On 13/05/2025 23:59, Judith Mendez wrote: >> Add documentation for PRU UART node which is for PRU serial UART >> based-off the industry standard TL16C550 asynchronous communications >> element. >> >> Signed-off-by: Judith Mendez <jm@ti.com> >> --- >> Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> > > Nothing in cover letter explains dependency and this the most important > part of cover letter. Otherwise how maintainers are supposed to guess > what they can take and what cannot? > > Squash the patch with previous in such case. Sure can do. > >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> index 927b3200e29e..54397297cbf5 100644 >> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> @@ -324,6 +324,13 @@ patternProperties: >> $ref: /schemas/net/ti,davinci-mdio.yaml# >> type: object >> >> + serial@[a-f0-9]+$: >> + description: | > > Do not need '|' unless you need to preserve formatting. Will fix this and first patch as well. Thanks ~ Judith
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml index 927b3200e29e..54397297cbf5 100644 --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml @@ -324,6 +324,13 @@ patternProperties: $ref: /schemas/net/ti,davinci-mdio.yaml# type: object + serial@[a-f0-9]+$: + description: | + Serial UART sub-module. A PRUSS can have a serial UART sub-module based + on the industry standard TL16C550 asynchronous communications element. + $ref: /schemas/serial/ti,pruss-uart.yaml# + type: object + "^(pru|rtu|txpru)@[0-9a-f]+$": description: | PRU Node. Each PRUSS has dual PRU cores, each represented as a RemoteProc
Add documentation for PRU UART node which is for PRU serial UART based-off the industry standard TL16C550 asynchronous communications element. Signed-off-by: Judith Mendez <jm@ti.com> --- Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 7 +++++++ 1 file changed, 7 insertions(+)