| Message ID | 20250221213837.1594057-1-naresh.solanki@9elements.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/2] dt-bindings: hwmon: ir38060: Move & update dt binding | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 61 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Sat, 22 Feb 2025 03:08:34 +0530, Naresh Solanki wrote: > Move dt binding under hwmon/pmbus & align accordingly. > > Previously the DT binding was invalid & wouldn't work with pmbus driver. > Pmbus driver expects a regulator node & hence added the same. > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > --- > Changes in V2: > 1. Update commit message > --- > .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++ > .../bindings/regulator/infineon,ir38060.yaml | 45 -------------- > 2 files changed, 61 insertions(+), 45 deletions(-) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml: maintainers:0: 'Not Me.' does not match '@' from schema $id: http://devicetree.org/meta-schemas/base.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250221213837.1594057-1-naresh.solanki@9elements.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Sat, Feb 22, 2025 at 03:08:34AM +0530, Naresh Solanki wrote: > Move dt binding under hwmon/pmbus & align accordingly. > > Previously the DT binding was invalid & wouldn't work with pmbus driver. > Pmbus driver expects a regulator node & hence added the same. This still doesn't really capture the previous discussion. With this, my response is still 'fix the driver'. It seems there is something about this is a common driver... > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > --- > Changes in V2: > 1. Update commit message > --- > .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++ > .../bindings/regulator/infineon,ir38060.yaml | 45 -------------- > 2 files changed, 61 insertions(+), 45 deletions(-) > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > new file mode 100644 > index 000000000000..e1f683846a54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Infineon Buck Regulators with PMBUS interfaces > + > +maintainers: > + - Not Me. > + > +properties: > + compatible: > + enum: > + - infineon,ir38060 > + - infineon,ir38064 > + - infineon,ir38164 > + - infineon,ir38263 > + > + reg: > + maxItems: 1 > + > + regulators: > + type: object > + description: > + list of regulators provided by this controller. > + > + properties: > + vout: > + $ref: /schemas/regulator/regulator.yaml# > + type: object > + > + unevaluatedProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + regulator@34 { > + compatible = "infineon,ir38060"; > + reg = <0x34>; > + > + regulators { > + vout { > + regulator-name = "p5v_aux"; > + regulator-min-microvolt = <437500>; > + regulator-max-microvolt = <1387500>; > + }; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml > deleted file mode 100644 > index e6ffbc2a2298..000000000000 > --- a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml > +++ /dev/null > @@ -1,45 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > -%YAML 1.2 > ---- > -$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml# > -$schema: http://devicetree.org/meta-schemas/core.yaml# > - > -title: Infineon Buck Regulators with PMBUS interfaces > - > -maintainers: > - - Not Me. > - > -allOf: > - - $ref: regulator.yaml# > - > -properties: > - compatible: > - enum: > - - infineon,ir38060 > - - infineon,ir38064 > - - infineon,ir38164 > - - infineon,ir38263 > - > - reg: > - maxItems: 1 > - > -required: > - - compatible > - - reg > - > -unevaluatedProperties: false > - > -examples: > - - | > - i2c { > - #address-cells = <1>; > - #size-cells = <0>; > - > - regulator@34 { > - compatible = "infineon,ir38060"; > - reg = <0x34>; > - > - regulator-min-microvolt = <437500>; > - regulator-max-microvolt = <1387500>; > - }; > - }; > > base-commit: 8df0f002827e18632dcd986f7546c1abf1953a6f > -- > 2.42.0 >
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml new file mode 100644 index 000000000000..e1f683846a54 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Infineon Buck Regulators with PMBUS interfaces + +maintainers: + - Not Me. + +properties: + compatible: + enum: + - infineon,ir38060 + - infineon,ir38064 + - infineon,ir38164 + - infineon,ir38263 + + reg: + maxItems: 1 + + regulators: + type: object + description: + list of regulators provided by this controller. + + properties: + vout: + $ref: /schemas/regulator/regulator.yaml# + type: object + + unevaluatedProperties: false + + additionalProperties: false + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + regulator@34 { + compatible = "infineon,ir38060"; + reg = <0x34>; + + regulators { + vout { + regulator-name = "p5v_aux"; + regulator-min-microvolt = <437500>; + regulator-max-microvolt = <1387500>; + }; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml deleted file mode 100644 index e6ffbc2a2298..000000000000 --- a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml +++ /dev/null @@ -1,45 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Infineon Buck Regulators with PMBUS interfaces - -maintainers: - - Not Me. - -allOf: - - $ref: regulator.yaml# - -properties: - compatible: - enum: - - infineon,ir38060 - - infineon,ir38064 - - infineon,ir38164 - - infineon,ir38263 - - reg: - maxItems: 1 - -required: - - compatible - - reg - -unevaluatedProperties: false - -examples: - - | - i2c { - #address-cells = <1>; - #size-cells = <0>; - - regulator@34 { - compatible = "infineon,ir38060"; - reg = <0x34>; - - regulator-min-microvolt = <437500>; - regulator-max-microvolt = <1387500>; - }; - };
Move dt binding under hwmon/pmbus & align accordingly. Previously the DT binding was invalid & wouldn't work with pmbus driver. Pmbus driver expects a regulator node & hence added the same. Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> --- Changes in V2: 1. Update commit message --- .../hwmon/pmbus/infineon,ir38060.yaml | 61 +++++++++++++++++++ .../bindings/regulator/infineon,ir38060.yaml | 45 -------------- 2 files changed, 61 insertions(+), 45 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml base-commit: 8df0f002827e18632dcd986f7546c1abf1953a6f