Message ID | 20241105064206.43626-3-hs@denx.de |
---|---|
State | Not Applicable |
Headers | show |
Series | arm64: dts: imx8mp: add support for the ABB SoM and carrier | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 1 warnings, 55 lines checked |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 05/11/2024 07:42, Heiko Schocher wrote: > Adding gpio-line-names property works fine for this > device node, but dtb check drops warning: > > 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/semtech,sx1501q.yaml# > > Allow to add property gpio-line-names for this devices. > > Signed-off-by: Heiko Schocher <hs@denx.de> > > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Nov 5, 2024 at 7:42 AM Heiko Schocher <hs@denx.de> wrote: > Adding gpio-line-names property works fine for this > device node, but dtb check drops warning: > > 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/semtech,sx1501q.yaml# > > Allow to add property gpio-line-names for this devices. > > Signed-off-by: Heiko Schocher <hs@denx.de> This patch 2/3 applied for v6.13. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml index 4214d7311f6b..39d7dad3313b 100644 --- a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml +++ b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml @@ -26,6 +26,10 @@ properties: reg: maxItems: 1 + gpio-line-names: + minItems: 5 + maxItems: 17 + interrupts: maxItems: 1 @@ -87,6 +91,45 @@ required: allOf: - $ref: pinctrl.yaml# + - if: + properties: + compatible: + contains: + enum: + - semtech,sx1501q + - semtech,sx1504q + - semtech,sx1507q + then: + properties: + gpio-line-names: + minItems: 5 + maxItems: 5 + - if: + properties: + compatible: + contains: + enum: + - semtech,sx1502q + - semtech,sx1505q + - semtech,sx1508q + then: + properties: + gpio-line-names: + minItems: 9 + maxItems: 9 + - if: + properties: + compatible: + contains: + enum: + - semtech,sx1503q + - semtech,sx1506q + - semtech,sx1509q + then: + properties: + gpio-line-names: + minItems: 17 + maxItems: 17 - if: not: properties:
Adding gpio-line-names property works fine for this device node, but dtb check drops warning: 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pinctrl/semtech,sx1501q.yaml# Allow to add property gpio-line-names for this devices. Signed-off-by: Heiko Schocher <hs@denx.de> --- checkpatch shows WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) 'gpio-line-names' does not match any of the regexes: '-cfg$', 'pinctrl-[0-9]+' Ignored, as it is a make output, which helps to understand the reason for adding this patch. Changes in v3: - worked in comments from Krzysztof gpio-line-names should match the actual number of gpios of the device. Changes in v2: patch dt-bindings: pinctrl: sx150xq: allow gpio line naming new in v2 .../bindings/pinctrl/semtech,sx1501q.yaml | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+)