| Message ID | 20240626112005.248576-4-ryan@testtoast.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Correct WL-355608-A8 panel compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Wed, Jun 26, 2024 at 11:17:50PM +1200, Ryan Walklin wrote: > make dt_bindings_check reports that sck-gpios and num-chipselects are > required for spi nodes, therefore add these to the example. > > Signed-off-by: Ryan Walklin <ryan@testtoast.com> huh, are you sure it does? It doesn't for me... > --- > .../bindings/display/panel/anbernic,rg35xx-panel.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml > index a7d5ad0f29389..610601c1594f3 100644 > --- a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml > +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml > @@ -40,6 +40,9 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > + sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9 > + num-chipselects = <1>; > + > panel@0 { > compatible = "anbernic,rg35xx-panel"; > reg = <0>; > -- > 2.45.2 >
Hi Conor, On Thu, 27 Jun 2024, at 3:38 AM, Conor Dooley wrote: > On Wed, Jun 26, 2024 at 11:17:50PM +1200, Ryan Walklin wrote: >> make dt_bindings_check reports that sck-gpios and num-chipselects are >> required for spi nodes, therefore add these to the example. > huh, are you sure it does? It doesn't for me... With: make dt_binding_check -j32 -s -W 2 I get the following output: /home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'num-chipselects' is a required property from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml# /home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'sck-gpios' is a required property from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml# The relevant section from spi-gpio.yaml seems to be: required: - compatible - num-chipselects - sck-gpios I am happy to leave this out if a simpler example is desired, but alternately if the chipselects/sck-gpios should stay then I would suggest a better example would include the mosi/miso/cs GPIOs as well which would make the example functional. Regards, Ryan
diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml index a7d5ad0f29389..610601c1594f3 100644 --- a/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml @@ -40,6 +40,9 @@ examples: #address-cells = <1>; #size-cells = <0>; + sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9 + num-chipselects = <1>; + panel@0 { compatible = "anbernic,rg35xx-panel"; reg = <0>;
make dt_bindings_check reports that sck-gpios and num-chipselects are required for spi nodes, therefore add these to the example. Signed-off-by: Ryan Walklin <ryan@testtoast.com> --- .../bindings/display/panel/anbernic,rg35xx-panel.yaml | 3 +++ 1 file changed, 3 insertions(+)