diff mbox series

[01/22] dt-bindings: thermal: samsung,exynos: specify cells

Message ID 20240614-dt-bindings-thermal-allof-v1-1-30b25a6ae24e@linaro.org
State Not Applicable
Headers show
Series dt-bindings: thermal: few cleanups | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Krzysztof Kozlowski June 14, 2024, 9:46 a.m. UTC
All Samsung Exynos SoCs Thermal Management Units have only one sensor,
so make '#thermal-sensor-cells' fixed at 0.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alim Akhtar June 14, 2024, 2:29 p.m. UTC | #1
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, June 14, 2024 3:16 PM
> To: Daniel Lezcano <daniel.lezcano@linaro.org
.stormreply.com;
> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
> 
> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
> make '#thermal-sensor-cells' fixed at 0.
> 
This is not entirely true, there are SoCs which have multiple temp sensors.
It is true that currently only one sensor support is added though.

So we can leave this as is or you suggest to make it to support only one sensor
(to match the current DT support), and later (in near future) change it again to
match what HW actually support?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 3
> ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> index 1344df708e2d..29a08b0729ee 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-
> thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.y
> +++ aml
> @@ -61,7 +61,8 @@ properties:
>            TRIMINFO at 0x10068000 contains data for TMU channel 2
>      minItems: 1
> 
> -  '#thermal-sensor-cells': true
> +  '#thermal-sensor-cells':
> +    const: 0
> 
>    vtmu-supply:
>      description: The regulator node supplying voltage to TMU.
> 
> --
> 2.43.0
Krzysztof Kozlowski June 15, 2024, 9:39 a.m. UTC | #2
On 14/06/2024 16:29, Alim Akhtar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Friday, June 14, 2024 3:16 PM
>> To: Daniel Lezcano <daniel.lezcano@linaro.org
> .stormreply.com;
>> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify cells
>>
>> All Samsung Exynos SoCs Thermal Management Units have only one sensor, so
>> make '#thermal-sensor-cells' fixed at 0.
>>
> This is not entirely true, there are SoCs which have multiple temp sensors.
> It is true that currently only one sensor support is added though.

All supported by mainline. Others do not exist now :)

> 
> So we can leave this as is or you suggest to make it to support only one sensor
> (to match the current DT support), and later (in near future) change it again to
> match what HW actually support?

Yes, different devices can have different value (and bindings).
Best regards,
Krzysztof
Alim Akhtar June 24, 2024, 4:06 a.m. UTC | #3
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Saturday, June 15, 2024 3:09 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; 'Krzysztof Kozlowski'
> <krzysztof.kozlowski@linaro.org>; 'Daniel Lezcano'
[snip]
> On 14/06/2024 16:29, Alim Akhtar wrote:
> > Hi Krzysztof,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Friday, June 14, 2024 3:16 PM
> >> To: Daniel Lezcano <daniel.lezcano@linaro.org
> > .stormreply.com;
> >> Subject: [PATCH 01/22] dt-bindings: thermal: samsung,exynos: specify
> >> cells
> >>
> >> All Samsung Exynos SoCs Thermal Management Units have only one
> >> sensor, so make '#thermal-sensor-cells' fixed at 0.
> >>
> > This is not entirely true, there are SoCs which have multiple temp sensors.
> > It is true that currently only one sensor support is added though.
> 
> All supported by mainline. Others do not exist now :)
> 
> >
> > So we can leave this as is or you suggest to make it to support only
> > one sensor (to match the current DT support), and later (in near
> > future) change it again to match what HW actually support?
> 
> Yes, different devices can have different value (and bindings).
Ok, this is fine for now.

> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
index 1344df708e2d..29a08b0729ee 100644
--- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
@@ -61,7 +61,8 @@  properties:
           TRIMINFO at 0x10068000 contains data for TMU channel 2
     minItems: 1
 
-  '#thermal-sensor-cells': true
+  '#thermal-sensor-cells':
+    const: 0
 
   vtmu-supply:
     description: The regulator node supplying voltage to TMU.