| Message ID | 20240613-ls_waring_esdhc-v5-1-36644e2fe21c@nxp.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm64: dts: convert fsl,esdhc.txt to yaml and fix layerscape dts warning | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, 13 Jun 2024 10:32:05 -0400, Frank Li wrote: > According to common mmc core, voltages-ranges should be matrix. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > Change from v4 to v5 > - Change maxItems to 1 > > Not sure why it impact other mmc yaml's voltage-ranges. > Rob's answer: > > It's a quirk of the tools. When decoding properties, the tools only know > all possible types. Types are global, not per binding. Sometimes it can > be figured out, but cases like this cannot be. > --- > Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml index 36acc40c7d181..6e2cdac6a85da 100644 --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml @@ -27,17 +27,19 @@ properties: maxItems: 1 voltage-ranges: - $ref: /schemas/types.yaml#/definitions/uint32-array + $ref: /schemas/types.yaml#/definitions/uint32-matrix description: | Two cells are required, first cell specifies minimum slot voltage (mV), second cell specifies maximum slot voltage (mV). items: - - description: | - value for minimum slot voltage in mV - default: 3200 - - description: | - value for maximum slot voltage in mV - default: 3400 + items: + - description: | + value for minimum slot voltage in mV + default: 3200 + - description: | + value for maximum slot voltage in mV + default: 3400 + maxItems: 1 gpios: description: |
According to common mmc core, voltages-ranges should be matrix. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v4 to v5 - Change maxItems to 1 Not sure why it impact other mmc yaml's voltage-ranges. Rob's answer: It's a quirk of the tools. When decoding properties, the tools only know all possible types. Types are global, not per binding. Sometimes it can be figured out, but cases like this cannot be. --- Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)