diff mbox series

[1/2] dt-bindings: arm: fsl: add i.MX93 9x9 QSB board

Message ID 20240605094812.1074027-1-peng.fan@oss.nxp.com
State Not Applicable
Headers show
Series [1/2] dt-bindings: arm: fsl: add i.MX93 9x9 QSB board | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Peng Fan June 5, 2024, 9:48 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Add compatible string for i.MX93 9x9 Quick Start Board.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley June 5, 2024, 4:56 p.m. UTC | #1 
On Wed, Jun 05, 2024 at 05:48:11PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add compatible string for i.MX93 9x9 Quick Start Board.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Fabio Estevam June 8, 2024, 4:38 p.m. UTC | #2 
On Wed, Jun 5, 2024 at 6:39 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:

> +&usdhc2 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +       pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> +       pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> +       cd-gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
> +       vmmc-supply = <&reg_usdhc2_vmmc>;
> +       bus-width = <4>;
> +       status = "okay";
> +       no-sdio;
> +       no-mmc;

Please remove 'no-sdio'.

On the imx93-11x11-evk, this property prevented me from connecting a
CMP9010 board into the usdhc2 slot:

https://lore.kernel.org/linux-arm-kernel/20240529034854.1595664-1-festevam@gmail.com/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 6d185d09cb6a..aeecf4e70dcf 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1272,6 +1272,7 @@  properties:
       - description: i.MX93 based Boards
         items:
           - enum:
+              - fsl,imx93-9x9-qsb         # i.MX93 9x9 QSB Board
               - fsl,imx93-11x11-evk       # i.MX93 11x11 EVK Board
           - const: fsl,imx93