| Message ID | 20240523080225.1288617-2-msp@baylibre.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | firmware: ti_sci: Partial-IO support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 10:02-20240523, Markus Schneider-Pargmann wrote: > Add a property with an array of phandles to devices that have pins that > are capable to wakeup the SoC from Partial-IO. In Partial-IO everything > is powered off including the DDR. Only pins belonging to a couple of > devices are active and wakeup the system on activity. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > index 7f06b1080244..c8ed0dd4fee4 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > @@ -61,6 +61,12 @@ properties: > mboxes: > minItems: 2 > > + ti,partial-io-wakeup-sources: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + List of phandles to devicetree nodes that can wakeup the SoC from the > + Partial IO poweroff mode. I think the description needs a bunch of improvement here. Can I use no board peripherals to be the phandle? say a GPIO expander irq? This is not clear from the patch how peripherals and pins are related? We also need to warn readers that this capability is firmware driven and not available on all SoC variants. > + > ti,host-id: > $ref: /schemas/types.yaml#/definitions/uint32 > description: | > -- > 2.43.0 >
On 23/05/2024 10:02, Markus Schneider-Pargmann wrote: > Add a property with an array of phandles to devices that have pins that > are capable to wakeup the SoC from Partial-IO. In Partial-IO everything > is powered off including the DDR. Only pins belonging to a couple of > devices are active and wakeup the system on activity. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > index 7f06b1080244..c8ed0dd4fee4 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml > @@ -61,6 +61,12 @@ properties: > mboxes: > minItems: 2 > > + ti,partial-io-wakeup-sources: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + List of phandles to devicetree nodes that can wakeup the SoC from the > + Partial IO poweroff mode. We have binding for this - wakeup-source in each device - what's wrong with it? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml index 7f06b1080244..c8ed0dd4fee4 100644 --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml @@ -61,6 +61,12 @@ properties: mboxes: minItems: 2 + ti,partial-io-wakeup-sources: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + List of phandles to devicetree nodes that can wakeup the SoC from the + Partial IO poweroff mode. + ti,host-id: $ref: /schemas/types.yaml#/definitions/uint32 description: |
Add a property with an array of phandles to devices that have pins that are capable to wakeup the SoC from Partial-IO. In Partial-IO everything is powered off including the DDR. Only pins belonging to a couple of devices are active and wakeup the system on activity. Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> --- Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++ 1 file changed, 6 insertions(+)