| Message ID | 20240519175906.138410-3-kanakshilledar111@protonmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: interrupt-controller: riscv,cpu-intc: | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 28 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote: > removed the redundant properties for interrupt-controller > and provide reference to the riscv,cpu-intc.yaml which defines > the interrupt-controller. making the properties for riscv > interrupt-controller at a central place. > > Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> > --- > .../devicetree/bindings/riscv/cpus.yaml | 22 +------------------ > 1 file changed, 1 insertion(+), 21 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed: Additional properties are not allowed ('$ref' was unexpected) 'type' is a required property hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@protonmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@kernel.org> wrote: > > > On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote: > > removed the redundant properties for interrupt-controller > > and provide reference to the riscv,cpu-intc.yaml which defines > > the interrupt-controller. making the properties for riscv > > interrupt-controller at a central place. > > > > Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> > > --- > > .../devicetree/bindings/riscv/cpus.yaml | 22 +------------------ > > 1 file changed, 1 insertion(+), 21 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed: > Additional properties are not allowed ('$ref' was unexpected) > 'type' is a required property > hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords > from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@protonmail.com I have fixed the above warning. > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. Can you please clarify this part? Is my base commit ID incorrect? I am currently using the 6.9.0-rc3 kernel version form https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/ repo. Thanks and Regards, Kanak Shilledar
On Mon, May 20, 2024 at 03:09:44PM +0530, Kanak Shilledar wrote: > On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@kernel.org> wrote: > > > > > > On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote: > > > removed the redundant properties for interrupt-controller > > > and provide reference to the riscv,cpu-intc.yaml which defines > > > the interrupt-controller. making the properties for riscv > > > interrupt-controller at a central place. > > > > > > Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> > > > --- > > > .../devicetree/bindings/riscv/cpus.yaml | 22 +------------------ > > > 1 file changed, 1 insertion(+), 21 deletions(-) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed: > > Additional properties are not allowed ('$ref' was unexpected) > > 'type' is a required property > > hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords > > from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml# > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@protonmail.com > > I have fixed the above warning. > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > Can you please clarify this part? Is my base commit ID incorrect? The bot says this in case the error is caused by it having applied patches on top of 6.9-rc1, but in this case I doubt there's any impact. By "this patch" it means that having the information in the cover doesn't help, but info about missing deps should go under the --- line etc. | base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23 | prerequisite-patch-id: 158157d32a32e765834a0cb4fc6335f9009d9962 | prerequisite-patch-id: 4007c7386e66f93b67a2631dddca08cadcee708b That said, why do you have two prerequisite patches? This applies on top of 6.9-rc3 without any issues (other than trailing whitespace warnings). Also, you forgot the v3 tag on this patchset, which confuses tooling: shazam https://lore.kernel.org/linux-riscv/20240519175906.138410-1-kanakshilledar111@protonmail.com/T/#t Grabbing thread from lore.kernel.org/all/20240519175906.138410-1-kanakshilledar111@protonmail.com/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org ---> Added from v2: 1 patches Analyzing 10 messages in the thread ---> Will use the latest revision: v2 You can pick other revisions using the -vN flag Checking attestation on all messages, may take a moment... Retrieving CI status, may take a moment... Some CI checks failed, see patchwork for more info: https://patchwork.kernel.org/project/linux-riscv/list/?series=854147 --- ✓ [● PATCH v2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema + Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- ✓ Signed: DKIM/gmail.com --- Total patches: 1 --- Applying: dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema Thanks, Conor.
Hi Conor, Thanks for the clarification. On Mon, May 20, 2024 at 10:34 PM Conor Dooley <conor@kernel.org> wrote: > > On Mon, May 20, 2024 at 03:09:44PM +0530, Kanak Shilledar wrote: > > On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@kernel.org> wrote: > > > > By "this patch" it means that having the information in the cover > doesn't help, but info about missing deps should go under the --- line > etc. I am still unable to get this part. I don't see there is any dependency other than the two patches dependent on each other. In my cover letter I have mentioned that the two patches are dependent on each other. > | base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23 > | prerequisite-patch-id: 158157d32a32e765834a0cb4fc6335f9009d9962 > | prerequisite-patch-id: 4007c7386e66f93b67a2631dddca08cadcee708b > > That said, why do you have two prerequisite patches? This applies on top > of 6.9-rc3 without any issues (other than trailing whitespace warnings). For generation the patches I am using the command: `git format-patch -2 -o outgoing/ --cover-letter --base=auto` It is automatically adding those two preqrequisite-patch-ids automatically along with the base-commit id. Is it due to the fact that I am having 2 older patches which I have rolled out already? Shall I remove those prerequisite patch id from the coverletter to solve this issue? > Also, you forgot the v3 tag on this patchset, which confuses tooling: I will fix it in my next version. I haven't changed anything in the patch so I will add the v3 tag and send it. > shazam https://lore.kernel.org/linux-riscv/20240519175906.138410-1-kanakshilledar111@protonmail.com/T/#t > Grabbing thread from lore.kernel.org/all/20240519175906.138410-1-kanakshilledar111@protonmail.com/t.mbox.gz > Checking for newer revisions > Grabbing search results from lore.kernel.org > ---> Added from v2: 1 patches > Analyzing 10 messages in the thread > ---> Will use the latest revision: v2 > You can pick other revisions using the -vN flag > Checking attestation on all messages, may take a moment... > Retrieving CI status, may take a moment... > Some CI checks failed, see patchwork for more info: > https://patchwork.kernel.org/project/linux-riscv/list/?series=854147 > --- > ✓ [● PATCH v2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema > + Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > ✓ Signed: DKIM/gmail.com > --- > Total patches: 1 > --- > Applying: dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema > > Thanks, > Conor. Thanks and Regards, Kanak Shilledar
On Tue, May 21, 2024 at 07:26:54PM +0530, Kanak Shilledar wrote: > Thanks for the clarification. > On Mon, May 20, 2024 at 10:34 PM Conor Dooley <conor@kernel.org> wrote: > > > > On Mon, May 20, 2024 at 03:09:44PM +0530, Kanak Shilledar wrote: > > > On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@kernel.org> wrote: > > > By "this patch" it means that having the information in the cover > > doesn't help, but info about missing deps should go under the --- line > > etc. > > I am still unable to get this part. I don't see there is any dependency > other than the two patches dependent on each other. In my cover letter > I have mentioned that the two patches are dependent on each other. That's fine, then you didn't do anything wrong in that regard. Sometimes however, other series have a dependency on other series, which is what that text was talking about. > > | base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23 > > | prerequisite-patch-id: 158157d32a32e765834a0cb4fc6335f9009d9962 > > | prerequisite-patch-id: 4007c7386e66f93b67a2631dddca08cadcee708b > > > > That said, why do you have two prerequisite patches? This applies on top > > of 6.9-rc3 without any issues (other than trailing whitespace warnings). > > For generation the patches I am using the command: > `git format-patch -2 -o outgoing/ --cover-letter --base=auto` > It is automatically adding those two preqrequisite-patch-ids > automatically along with the base-commit id. > Is it due to the fact that I am having 2 older patches which I have > rolled out already? Shall I remove those > prerequisite patch id from the coverletter to solve this issue? If they're not related to what you're working on, then yes. --base=auto probably picked the last tagged commit, but the applier of these patches doesn't need to care about the other (unrelated) patches in your tree so having them is just a potential source of confusion.
diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml index d87dd50f1a4b..b90bb83c8e73 100644 --- a/Documentation/devicetree/bindings/riscv/cpus.yaml +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml @@ -101,27 +101,7 @@ properties: timebase-frequency: false interrupt-controller: - type: object - additionalProperties: false - description: Describes the CPU's local interrupt controller - - properties: - '#interrupt-cells': - const: 1 - - compatible: - oneOf: - - items: - - const: andestech,cpu-intc - - const: riscv,cpu-intc - - const: riscv,cpu-intc - - interrupt-controller: true - - required: - - '#interrupt-cells' - - compatible - - interrupt-controller + $ref: /schemas/interrupt-controller/riscv,cpu-intc.yaml cpu-idle-states: $ref: /schemas/types.yaml#/definitions/phandle-array
removed the redundant properties for interrupt-controller and provide reference to the riscv,cpu-intc.yaml which defines the interrupt-controller. making the properties for riscv interrupt-controller at a central place. Signed-off-by: Kanak Shilledar <kanakshilledar111@protonmail.com> --- .../devicetree/bindings/riscv/cpus.yaml | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-)