| Message ID | 20240509110545.49889-1-linux@fw-web.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: leds: mark label as depected to match description | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/05/2024 13:05, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > The description for property 'label' describes it as deprected, so Typos here and in subject. > add a option to mark it like that. Future devicetrees should use > function and color properties. > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema") Nooo, that's not a fix. I don't think there was conclusion to make it deprecated on last attempt: https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electronics.com/ Best regards, Krzysztof
Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto: > On 09/05/2024 13:05, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> The description for property 'label' describes it as deprected, so > > Typos here and in subject. > > >> add a option to mark it like that. Future devicetrees should use >> function and color properties. >> >> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema") > > Nooo, that's not a fix. > > I don't think there was conclusion to make it deprecated on last attempt: > > https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electronics.com/ > It's not a fix, agreed. But that property being deprecated deserves to be marked as deprecated, anyway. Otherwise the documentation shouldn't say in words that it is such. Cheers, Angelo
On Thu 2024-05-09 14:39:36, AngeloGioacchino Del Regno wrote: > Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto: > > On 09/05/2024 13:05, Frank Wunderlich wrote: > > > From: Frank Wunderlich <frank-w@public-files.de> > > > > > > The description for property 'label' describes it as deprected, so > > > > Typos here and in subject. > > > > > > > add a option to mark it like that. Future devicetrees should use > > > function and color properties. > > > > > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema") > > > > Nooo, that's not a fix. > > > > I don't think there was conclusion to make it deprecated on last attempt: > > > > https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electronics.com/ > > > > It's not a fix, agreed. > > But that property being deprecated deserves to be marked as deprecated, anyway. > Otherwise the documentation shouldn't say in words that it is such. Fix the docs. We are not ready to deprecate that. Best regards, Pavel
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 8a3c2398b10c..2d7331bba1fc 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -58,6 +58,7 @@ properties: no other LED class device can be assigned the same label. This property is deprecated - use 'function' and 'color' properties instead. function-enumerator has no effect when this property is present. + deprecated: true default-state: description: