| Message ID | 20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1,1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 09 May 2024 14:43:35 +0800, Zhaoxiong Lv wrote: > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: [error] duplication of key "const" in mapping (key-duplicates) dtschema/dtc warnings/errors: make[2]: *** Deleting file 'Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts' Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/input/ilitek,ili9882t.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml:22:5: found duplicate key "const" with value "ilitek,ili2900" (original value: "ilitek,ili9882t") /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml: ignoring, error parsing file make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 make: *** [Makefile:240: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240509064336.9803-1-lvzhaoxiong@huaqin.corp-partner.google.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 09/05/2024 08:43, Zhaoxiong Lv wrote: > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> You just sent the same, ignoring entire feedback. That's a shortcut to get ignored on your contributions... :( Best regards, Krzysztof
Hi, On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the post_gpio_reset_on_delay_ms is set to 100. > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > --- > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ > 1 file changed, 8 insertions(+) You silently ignored pretty much all of the feedback from the previous version [1], so I'm not planning to review this version. [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com
hi Doug Sorry, This patch was accidentally sent when sending other patches. Please ignore this patch. > Also: other than the main power supply, there is no difference between > this and the ili2901. If you actually do have a main power supply, > then you probably don't need a new table. You probably don't even need > your own compatible string and in the device tree you could just > specify: > compatible = "ilitek,ili2900, "ilitek,ili2901"; > ...which says "I actually have an ILI 2900, but if you don't have any > special driver for the ILI 2900 it's likely that the driver for the > ILI 2901 will work because the hardware is almost the same." In addition, in the previous patch, we have made modifications based on your suggestions. "ilitek ili2900" and "ilitek ili2901" use the same driver. Upstream may not be needed in the future. Thank you for your previous suggestions. [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com On Thu, May 9, 2024 at 10:35 PM Doug Anderson <dianders@google.com> wrote: > > Hi, > > On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > From: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > > > ILI2900 requires reset to pull down time greater than 10ms, > > so the configuration post_power_delay_ms is 10, and the chipset > > initial time is required to be greater than 100ms, > > so the post_gpio_reset_on_delay_ms is set to 100. > > > > Signed-off-by: lvzhaoxiong <lvzhaoxiong@huaqin.corp-partner.google.com> > > --- > > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > You silently ignored pretty much all of the feedback from the previous > version [1], so I'm not planning to review this version. > > [1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com
diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml index c5d9e0e919f9..5063ea2c8375 100644 --- a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml @@ -19,6 +19,7 @@ allOf: properties: compatible: const: ilitek,ili9882t + const: ilitek,ili2900 reg: const: 0x41