| Message ID | 20240414-raydium-rm69380-driver-v1-1-5e86ba2490b5@mainlining.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add driver for Raydium RM69380-based DSI panels | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 14/04/2024 17:22, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek <david@mainlining.org> > --- > .../bindings/display/panel/raydium,rm69380.yaml | 94 ++++++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > new file mode 100644 > index 000000000000..9b01b9c22ae9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Raydium RM6380-based DSI display panels > + > +maintainers: > + - David Wronek <david@mainlining.org> > + > +description: > + The Raydium RM69380 is a generic DSI Panel IC used to control > + OLED panels. > + > +properties: > + compatible: > + items: > + - const: lenovo,j716f-edo-rm69380 > + - const: raydium,rm69380 > + > + avdd-supply: > + description: Analog voltage rail > + > + vddio-supply: > + description: I/O voltage rail > + > + reset-gpios: > + maxItems: 1 > + > + reg: true > + > +required: > + - compatible > + - reg > + - avdd-supply > + - vddio-supply > + - reset-gpios > + > +allOf: > + - $ref: panel-common-dual.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - lenovo,j716f-edo-rm69380 You have only one variant, so entire if: is not needed. Just require ports in top-level, if you say this device cannot support single-link (just to remind: we talk about what device supports, not driver). > + then: > + properties: > + port: false Redundant, drop. > + ports: > + required: > + - port@1 > + Best regards, Krzysztof
On Sun, 14 Apr 2024 17:22:30 +0200, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek <david@mainlining.org> > --- > .../bindings/display/panel/raydium,rm69380.yaml | 94 ++++++++++++++++++++++ > 1 file changed, 94 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/raydium,rm69380.example.dtb: panel@0: False schema does not allow {'compatible': ['lenovo,j716f-edo-rm69380', 'raydium,rm69380'], 'reg': [[0]], 'avdd-supply': [[4294967295]], 'vddio-supply': [[4294967295]], 'reset-gpios': [[4294967295, 75, 1]], 'ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'endpoint': {'remote-endpoint': [[4294967295]]}}, 'port@1': {'reg': [[1]], 'endpoint': {'remote-endpoint': [[4294967295]]}}}, '$nodename': ['panel@0']} from schema $id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240414-raydium-rm69380-driver-v1-1-5e86ba2490b5@mainlining.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml new file mode 100644 index 000000000000..9b01b9c22ae9 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml @@ -0,0 +1,94 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raydium RM6380-based DSI display panels + +maintainers: + - David Wronek <david@mainlining.org> + +description: + The Raydium RM69380 is a generic DSI Panel IC used to control + OLED panels. + +properties: + compatible: + items: + - const: lenovo,j716f-edo-rm69380 + - const: raydium,rm69380 + + avdd-supply: + description: Analog voltage rail + + vddio-supply: + description: I/O voltage rail + + reset-gpios: + maxItems: 1 + + reg: true + +required: + - compatible + - reg + - avdd-supply + - vddio-supply + - reset-gpios + +allOf: + - $ref: panel-common-dual.yaml# + - if: + properties: + compatible: + contains: + enum: + - lenovo,j716f-edo-rm69380 + then: + properties: + port: false + ports: + required: + - port@1 + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "lenovo,j716f-edo-rm69380", "raydium,rm69380"; + reg = <0>; + + avdd-supply = <&panel_avdd_regulator>; + vddio-supply = <&vreg_l14a>; + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + panel_in_0: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + + port@1 { + reg = <1>; + panel_in_1: endpoint { + remote-endpoint = <&mdss_dsi1_out>; + }; + }; + }; + }; + }; + +...
Raydium RM69380 is a display driver IC used to drive OLED DSI panels. Add a dt-binding for it. Signed-off-by: David Wronek <david@mainlining.org> --- .../bindings/display/panel/raydium,rm69380.yaml | 94 ++++++++++++++++++++++ 1 file changed, 94 insertions(+)