| Message ID | 20240408132241.750792-2-neeraj.sanjaykale@nxp.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Bluetooth: btnxpuart: Update firmware names | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 08/04/2024 15:22, Neeraj Sanjay Kale wrote: > This adds a new optional device tree property called firware-name. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> BTW, there is no such device as btnxpuart. Bindings are for hardware. With corrected subject: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof) > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > index f01a3988538c..6774cc4d6a9e 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > @@ -31,6 +31,11 @@ properties: > This property depends on the module vendor's > configuration. > > + firmware-name: > + maxItems: 1 > + description: > + Specify firmware file name. Drop description, redundant. You did not say anything different than property is saying already. Best regards, Krzysztof
Hi Krzysztof, Thank you for the review. I have made the changes you requested and sent out the v3 patch. Thanks, Neeraj > > On 08/04/2024 15:22, Neeraj Sanjay Kale wrote: > > This adds a new optional device tree property called firware-name. > > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > > BTW, there is no such device as btnxpuart. Bindings are for hardware. > With corrected subject: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof) > > --- > > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > index f01a3988538c..6774cc4d6a9e 100644 > > --- > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y > > +++ aml > > @@ -31,6 +31,11 @@ properties: > > This property depends on the module vendor's > > configuration. > > > > + firmware-name: > > + maxItems: 1 > > + description: > > + Specify firmware file name. > > Drop description, redundant. You did not say anything different than property > is saying already.
diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml index f01a3988538c..6774cc4d6a9e 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml @@ -31,6 +31,11 @@ properties: This property depends on the module vendor's configuration. + firmware-name: + maxItems: 1 + description: + Specify firmware file name. + required: - compatible @@ -42,5 +47,6 @@ examples: bluetooth { compatible = "nxp,88w8987-bt"; fw-init-baudrate = <3000000>; + firmware-name = "uartuart8987_bt_v0.bin"; }; };
This adds a new optional device tree property called firware-name. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- v2: Add maxItems, simplify description, remove "nxp/". (Krzysztof) --- .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 6 ++++++ 1 file changed, 6 insertions(+)