| Message ID | 20240408085931.456337-2-avkrasnov@salutedevices.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Meson: R/W support for pages used by boot ROM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
Hi Arseniy, kernel test robot noticed the following build warnings: [auto build test WARNING on mtd/mtd/next] [also build test WARNING on mtd/mtd/fixes mtd/nand/next robh/for-next linus/master v6.9-rc3 next-20240408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arseniy-Krasnov/dt-bindings-mtd-amlogic-meson-nand-support-fields-for-boot-ROM-code/20240408-171119 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next patch link: https://lore.kernel.org/r/20240408085931.456337-2-avkrasnov%40salutedevices.com patch subject: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240409/202404090420.FyEkmAU9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202404090420.FyEkmAU9-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:84:61: [warning] too few spaces after comma (commas) Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:85:61: [warning] too few spaces after comma (commas) vim +84 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml 8 9 allOf: 10 - $ref: nand-controller.yaml 11 12 maintainers: 13 - liang.yang@amlogic.com 14 15 properties: 16 compatible: 17 enum: 18 - amlogic,meson-gxl-nfc 19 - amlogic,meson-axg-nfc 20 21 reg: 22 maxItems: 2 23 24 reg-names: 25 items: 26 - const: nfc 27 - const: emmc 28 29 interrupts: 30 maxItems: 1 31 32 clocks: 33 minItems: 2 34 35 clock-names: 36 items: 37 - const: core 38 - const: device 39 40 patternProperties: 41 "^nand@[0-7]$": 42 type: object 43 $ref: raw-nand-chip.yaml 44 properties: 45 reg: 46 minimum: 0 47 maximum: 1 48 49 nand-ecc-mode: 50 const: hw 51 52 nand-ecc-step-size: 53 enum: [512, 1024] 54 55 nand-ecc-strength: 56 enum: [8, 16, 24, 30, 40, 50, 60] 57 description: | 58 The ECC configurations that can be supported are as follows. 59 meson-gxl-nfc 8, 16, 24, 30, 40, 50, 60 60 meson-axg-nfc 8 61 62 nand-rb: 63 maxItems: 1 64 items: 65 maximum: 0 66 67 amlogic,boot-page-last: 68 $ref: /schemas/types.yaml#/definitions/uint32 69 description: 70 The NFC driver needs this information to select ECC 71 algorithms supported by the boot ROM. 72 73 amlogic,boot-page-step: 74 $ref: /schemas/types.yaml#/definitions/uint32 75 description: 76 The NFC driver needs this information to select ECC 77 algorithms supported by the boot ROM (in pages). 78 79 unevaluatedProperties: false 80 81 dependencies: 82 nand-ecc-strength: [nand-ecc-step-size] 83 nand-ecc-step-size: [nand-ecc-strength] > 84 amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] 85 amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] 86 87 88 required: 89 - compatible 90 - reg 91 - interrupts 92 - clocks 93 - clock-names 94
On Mon, 08 Apr 2024 11:59:30 +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com> > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:84:61: [warning] too few spaces after comma (commas) ./Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml:85:61: [warning] too few spaces after comma (commas) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240408085931.456337-2-avkrasnov@salutedevices.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. > > Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com> > --- > .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 57b6957c8415..80ba5003ca70 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -64,11 +64,25 @@ patternProperties: > items: > maximum: 0 > > + amlogic,boot-page-last: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM. > + > + amlogic,boot-page-step: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The NFC driver needs this information to select ECC > + algorithms supported by the boot ROM (in pages). > + > unevaluatedProperties: false > > dependencies: > nand-ecc-strength: [nand-ecc-step-size] > nand-ecc-step-size: [nand-ecc-strength] > + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] > + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] You need quotes if using the inline syntax. Rob
On 09.04.2024 16:47, Rob Herring wrote: > On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: >> Boot ROM code on Meson requires that some pages on NAND must be written >> in special mode: "short" ECC mode where each block is 384 bytes and >> scrambling mode is on. Such pages located with the specified interval >> within specified offset. Both interval and offset are located in the >> device tree and used by driver if 'nand-is-boot-medium' is set for >> NAND chip. >> >> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com> >> --- >> .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> index 57b6957c8415..80ba5003ca70 100644 >> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> @@ -64,11 +64,25 @@ patternProperties: >> items: >> maximum: 0 >> >> + amlogic,boot-page-last: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The NFC driver needs this information to select ECC >> + algorithms supported by the boot ROM. >> + >> + amlogic,boot-page-step: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The NFC driver needs this information to select ECC >> + algorithms supported by the boot ROM (in pages). >> + >> unevaluatedProperties: false >> >> dependencies: >> nand-ecc-strength: [nand-ecc-step-size] >> nand-ecc-step-size: [nand-ecc-strength] >> + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] >> + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] > > You need quotes if using the inline syntax. IIUC it must look like this: amlogic,boot-page-last: [nand-is-boot-medium, "amlogic,boot-page-step"] etc. > > Rob
diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml index 57b6957c8415..80ba5003ca70 100644 --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml @@ -64,11 +64,25 @@ patternProperties: items: maximum: 0 + amlogic,boot-page-last: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + The NFC driver needs this information to select ECC + algorithms supported by the boot ROM. + + amlogic,boot-page-step: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + The NFC driver needs this information to select ECC + algorithms supported by the boot ROM (in pages). + unevaluatedProperties: false dependencies: nand-ecc-strength: [nand-ecc-step-size] nand-ecc-step-size: [nand-ecc-strength] + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] required:
Boot ROM code on Meson requires that some pages on NAND must be written in special mode: "short" ECC mode where each block is 384 bytes and scrambling mode is on. Such pages located with the specified interval within specified offset. Both interval and offset are located in the device tree and used by driver if 'nand-is-boot-medium' is set for NAND chip. Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com> --- .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)