| Message ID | 20240401190506.3238885-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3] media: dt-bindings: ovti,ov2680: Document more properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 39 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 01/04/2024 21:05, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > OV2680 has a single data lane MIPI interface. The hardware or the driver? > > Document the clock-lanes and data-lanes properties to avoid > the following dt-schema warning: > > imx7s-warp.dtb: camera@36: port:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes' were unexpected) > from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml# You should mention why you cannot drop the redundant clock/data-lanes from DTS. > > While at it, also document the link-frequencies property as recommended > by the following document: > > https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks > > Signed-off-by: Fabio Estevam <festevam@denx.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml index cf456f8d9ddc..6ae7d4457536 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml @@ -50,9 +50,29 @@ properties: Definition of the regulator used as digital power supply. port: - $ref: /schemas/graph.yaml#/properties/port description: A node containing an output port node. + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + additionalProperties: false + + properties: + clock-lanes: + const: 0 + + data-lanes: + const: 1 + + link-frequencies: true + + remote-endpoint: true + + required: + - link-frequencies required: - compatible @@ -89,6 +109,9 @@ examples: port { ov2680_to_mipi: endpoint { remote-endpoint = <&mipi_from_sensor>; + clock-lanes = <0>; + data-lanes = <1>; + link-frequencies = /bits/ 64 <330000000>; }; }; };