| Message ID | 20240328014029.9710-1-animeshagarwal28@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: ti,pcm1681: Convert to dtschema | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 35 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 28/03/2024 02:40, Animesh Agarwal wrote: > Convert the Texas Instruments PCM1681 bindings to DT schema. > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> > --- > .../devicetree/bindings/sound/ti,pcm1681.txt | 15 -------- > .../devicetree/bindings/sound/ti,pcm1681.yaml | 35 +++++++++++++++++++ > 2 files changed, 35 insertions(+), 15 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/ti,pcm1681.txt > create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm1681.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.txt b/Documentation/devicetree/bindings/sound/ti,pcm1681.txt > deleted file mode 100644 > index 4df17185ab80..000000000000 > --- a/Documentation/devicetree/bindings/sound/ti,pcm1681.txt > +++ /dev/null > @@ -1,15 +0,0 @@ > -Texas Instruments PCM1681 8-channel PWM Processor > - > -Required properties: > - > - - compatible: Should contain "ti,pcm1681". > - - reg: The i2c address. Should contain <0x4c>. > - > -Examples: > - > - i2c_bus { > - pcm1681@4c { > - compatible = "ti,pcm1681"; > - reg = <0x4c>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml > new file mode 100644 > index 000000000000..4093d0ff654d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,pcm1681.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments PCM1681 8-channel PWM Processor > + > +maintainers: > + - Animesh Agarwal <animeshagarwal28@gmail.com> Why not existing driver maintainers? Do you have this device? Or use it, or care in terms of your projects? > + > +properties: > + compatible: > + const: ti,pcm1681 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + Missing dai-cells, $ref to dai-common and unevaluatedProperties: false, just like in other simple DAI devices. Mention briefly in the commit msg adding these ("Make bindings complete by adding #sound-dai-cells"). > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pcm1681@4c { Datasheet says it is dac, but we usually call it "audio-codec". > + compatible = "ti,pcm1681"; > + reg = <0x4c>; > + }; > + }; Best regards, Krzysztof
On Thu, Mar 28, 2024 at 2:27 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Why not existing driver maintainers? Do you have this device? Or use it, > or care in terms of your projects? I'll change it to the current maintainers of the bindings. > Missing dai-cells, $ref to dai-common and unevaluatedProperties: false, > just like in other simple DAI devices. Mention briefly in the commit msg > adding these ("Make bindings complete by adding #sound-dai-cells"). Sure, I'll add it. > Datasheet says it is dac, but we usually call it "audio-codec". > Noted. Thanks and Regards, Animesh Agarwal
diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.txt b/Documentation/devicetree/bindings/sound/ti,pcm1681.txt deleted file mode 100644 index 4df17185ab80..000000000000 --- a/Documentation/devicetree/bindings/sound/ti,pcm1681.txt +++ /dev/null @@ -1,15 +0,0 @@ -Texas Instruments PCM1681 8-channel PWM Processor - -Required properties: - - - compatible: Should contain "ti,pcm1681". - - reg: The i2c address. Should contain <0x4c>. - -Examples: - - i2c_bus { - pcm1681@4c { - compatible = "ti,pcm1681"; - reg = <0x4c>; - }; - }; diff --git a/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml new file mode 100644 index 000000000000..4093d0ff654d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,pcm1681.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,pcm1681.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments PCM1681 8-channel PWM Processor + +maintainers: + - Animesh Agarwal <animeshagarwal28@gmail.com> + +properties: + compatible: + const: ti,pcm1681 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pcm1681@4c { + compatible = "ti,pcm1681"; + reg = <0x4c>; + }; + };
Convert the Texas Instruments PCM1681 bindings to DT schema. Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com> --- .../devicetree/bindings/sound/ti,pcm1681.txt | 15 -------- .../devicetree/bindings/sound/ti,pcm1681.yaml | 35 +++++++++++++++++++ 2 files changed, 35 insertions(+), 15 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ti,pcm1681.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm1681.yaml