| Message ID | 20240327231710.53188-18-git@luigi311.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | v2: imx258 improvement series | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: > From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > imx258.yaml doesn't include the vendor prefix of sony, so > rename to add it. > Update the id entry and MAINTAINERS to match. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> This is a v1 with my ack, something has gone awry here. It's also missing your signoff. Did you pick up someone else's series? > --- > .../bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} | 2 +- > MAINTAINERS | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (97%) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > similarity index 97% > rename from Documentation/devicetree/bindings/media/i2c/imx258.yaml > rename to Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index 80d24220baa0..bee61a443b23 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > +$id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > diff --git a/MAINTAINERS b/MAINTAINERS > index aa3b947fb080..1f17f6734bf5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20464,7 +20464,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com> > L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > -F: Documentation/devicetree/bindings/media/i2c/imx258.yaml > +F: Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > F: drivers/media/i2c/imx258.c > > SONY IMX274 SENSOR DRIVER > -- > 2.42.0 >
On 3/27/24 17:47, Conor Dooley wrote: > On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> >> >> imx258.yaml doesn't include the vendor prefix of sony, so >> rename to add it. >> Update the id entry and MAINTAINERS to match. >> >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > This is a v1 with my ack, something has gone awry here. It's also > missing your signoff. Did you pick up someone else's series? Yes, this is a continuation of Dave's work. I contacted him directly, and he mentioned that he is unable to submit a v2 any time soon and was open to someone else continuing it in his stead. This is my first time submitting a patch via a mailing list, so I'm not sure if I'm missing something, but I only added my sign off for anything that actually included work from my side and not just bringing his patch forward to this patch series. > >> --- >> .../bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} | 2 +- >> MAINTAINERS | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (97%) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> similarity index 97% >> rename from Documentation/devicetree/bindings/media/i2c/imx258.yaml >> rename to Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index 80d24220baa0..bee61a443b23 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> %YAML 1.2 >> --- >> -$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# >> +$id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor >> diff --git a/MAINTAINERS b/MAINTAINERS >> index aa3b947fb080..1f17f6734bf5 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -20464,7 +20464,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com> >> L: linux-media@vger.kernel.org >> S: Maintained >> T: git git://linuxtv.org/media_tree.git >> -F: Documentation/devicetree/bindings/media/i2c/imx258.yaml >> +F: Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> F: drivers/media/i2c/imx258.c >> >> SONY IMX274 SENSOR DRIVER >> -- >> 2.42.0 >>
Quoting git@luigi311.com (2024-03-28 00:57:34) > On 3/27/24 17:47, Conor Dooley wrote: > > On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: > >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> > >> imx258.yaml doesn't include the vendor prefix of sony, so > >> rename to add it. > >> Update the id entry and MAINTAINERS to match. > >> > >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > This is a v1 with my ack, something has gone awry here. It's also > > missing your signoff. Did you pick up someone else's series? > > Yes, this is a continuation of Dave's work. I contacted him directly, > and he mentioned that he is unable to submit a v2 any time soon and > was open to someone else continuing it in his stead. This is my first > time submitting a patch via a mailing list, so I'm not sure if I'm > missing something, but I only added my sign off for anything that > actually included work from my side and not just bringing his patch > forward to this patch series. Your cover letter states v2, but the individual patches do not. Add the '-v2' (or, rather, next it will be '-v3') to git format-patch when you save your series and it will add the version to each patch. You can also add '-s' to that command I believe to add your SoB to each patch. -- Kieran > > > > >> --- > >> .../bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} | 2 +- > >> MAINTAINERS | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (97%) > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> similarity index 97% > >> rename from Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> rename to Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> index 80d24220baa0..bee61a443b23 100644 > >> --- a/Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> @@ -1,7 +1,7 @@ > >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> %YAML 1.2 > >> --- > >> -$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# > >> +$id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml# > >> $schema: http://devicetree.org/meta-schemas/core.yaml# > >> > >> title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index aa3b947fb080..1f17f6734bf5 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -20464,7 +20464,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com> > >> L: linux-media@vger.kernel.org > >> S: Maintained > >> T: git git://linuxtv.org/media_tree.git > >> -F: Documentation/devicetree/bindings/media/i2c/imx258.yaml > >> +F: Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > >> F: drivers/media/i2c/imx258.c > >> > >> SONY IMX274 SENSOR DRIVER > >> -- > >> 2.42.0 > >> >
On Thu, Mar 28, 2024 at 08:52:01AM +0000, Kieran Bingham wrote: > Quoting git@luigi311.com (2024-03-28 00:57:34) > > On 3/27/24 17:47, Conor Dooley wrote: > > > On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: > > >> From: Dave Stevenson <dave.stevenson@raspberrypi.com> > > >> > > >> imx258.yaml doesn't include the vendor prefix of sony, so > > >> rename to add it. > > >> Update the id entry and MAINTAINERS to match. > > >> > > >> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > > This is a v1 with my ack, something has gone awry here. It's also > > > missing your signoff. Did you pick up someone else's series? > > > > Yes, this is a continuation of Dave's work. I contacted him directly, > > and he mentioned that he is unable to submit a v2 any time soon and > > was open to someone else continuing it in his stead. Ah okay. Unfortunately I see so many binding patches pass by that I sometimes forget about what I already reviewed, and I did not remember this one at all. > > This is my first > > time submitting a patch via a mailing list, so I'm not sure if I'm > > missing something, but I only added my sign off for anything that > > actually included work from my side and not just bringing his patch > > forward to this patch series. Right. The rules are that you need to add it when you send someone's work, like chain of custody type of thing. > Your cover letter states v2, but the individual patches do not. > > Add the '-v2' (or, rather, next it will be '-v3') to git format-patch > when you save your series and it will add the version to each patch. You > can also add '-s' to that command I believe to add your SoB to each > patch. or a rebase will do it with --signoff: https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---signoff Cheers, Conor.
On 3/28/24 04:15, Conor Dooley wrote: > On Thu, Mar 28, 2024 at 08:52:01AM +0000, Kieran Bingham wrote: >> Quoting git@luigi311.com (2024-03-28 00:57:34) >>> On 3/27/24 17:47, Conor Dooley wrote: >>>> On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@luigi311.com wrote: >>>>> From: Dave Stevenson <dave.stevenson@raspberrypi.com> >>>>> >>>>> imx258.yaml doesn't include the vendor prefix of sony, so >>>>> rename to add it. >>>>> Update the id entry and MAINTAINERS to match. >>>>> >>>>> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> >>>>> Acked-by: Conor Dooley <conor.dooley@microchip.com> >>>> >>>> This is a v1 with my ack, something has gone awry here. It's also >>>> missing your signoff. Did you pick up someone else's series? >>> >>> Yes, this is a continuation of Dave's work. I contacted him directly, >>> and he mentioned that he is unable to submit a v2 any time soon and >>> was open to someone else continuing it in his stead. > > Ah okay. Unfortunately I see so many binding patches pass by that I > sometimes forget about what I already reviewed, and I did not > remember this one at all. No worries I'm not surprised since i see constant things submitted to upstream and v1 was actually sent a year ago so there would be no shot that i would remember it either. > >>> This is my first >>> time submitting a patch via a mailing list, so I'm not sure if I'm >>> missing something, but I only added my sign off for anything that >>> actually included work from my side and not just bringing his patch >>> forward to this patch series. > > Right. The rules are that you need to add it when you send someone's > work, like chain of custody type of thing. Ohh i see, ok ill go ahead and add my sign off to all the patches then > >> Your cover letter states v2, but the individual patches do not. >> >> Add the '-v2' (or, rather, next it will be '-v3') to git format-patch >> when you save your series and it will add the version to each patch. You >> can also add '-s' to that command I believe to add your SoB to each >> patch. > > or a rebase will do it with --signoff: > https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---signoff Perfect thanks for the information you two! Ill be sure to use those for the next revision. > > Cheers, > Conor.
diff --git a/Documentation/devicetree/bindings/media/i2c/imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml similarity index 97% rename from Documentation/devicetree/bindings/media/i2c/imx258.yaml rename to Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index 80d24220baa0..bee61a443b23 100644 --- a/Documentation/devicetree/bindings/media/i2c/imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/media/i2c/imx258.yaml# +$id: http://devicetree.org/schemas/media/i2c/sony,imx258.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Sony IMX258 13 Mpixel CMOS Digital Image Sensor diff --git a/MAINTAINERS b/MAINTAINERS index aa3b947fb080..1f17f6734bf5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20464,7 +20464,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com> L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git -F: Documentation/devicetree/bindings/media/i2c/imx258.yaml +F: Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml F: drivers/media/i2c/imx258.c SONY IMX274 SENSOR DRIVER