| Message ID | 20240326-rk-default-enable-strobe-pulldown-v1-2-f410c71605c0@folker-schwesinger.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: rockchip: emmc: Enable internal strobe pull-down by default | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 10 lines checked |
| robh/patch-applied | success |
On Tue, Mar 26, 2024 at 07:54:36PM +0100, Folker Schwesinger via B4 Relay wrote: > From: Folker Schwesinger <dev@folker-schwesinger.de> The prefix is "dt-bindings" not "devicetree" FYI. > > Document the changes regarding the optional strobe-pulldown property. > These changes are necessary as the default behavior of the driver was > restored to the Rockchip kernel behavior of enabling the internal > pulldown by default. I don't think this is a valid justification, but it'll be easier for me to explain this on the driver patch. Thanks, Conor. > > Fixes: f34e43f12382 ("devicetree: phy: rockchip-emmc: pulldown property") > Signed-off-by: Folker Schwesinger <dev@folker-schwesinger.de> > --- > Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > index 57d28c0d5696..10c05437f7ab 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > @@ -16,8 +16,8 @@ Optional properties: > - drive-impedance-ohm: Specifies the drive impedance in Ohm. > Possible values are 33, 40, 50, 66 and 100. > If not set, the default value of 50 will be applied. > - - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe > - line. If not set, pull-down is not used. > + - rockchip,disable-strobe-pulldown: Disable internal pull-down for the strobe > + line. If not set, pull-down is used. > - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register. > If not set, the register defaults to 0x4. > Maximum value 0xf. > > -- > 2.44.0 > >
On 26/03/2024 19:54, Folker Schwesinger via B4 Relay wrote: > From: Folker Schwesinger <dev@folker-schwesinger.de> > > Document the changes regarding the optional strobe-pulldown property. > These changes are necessary as the default behavior of the driver was > restored to the Rockchip kernel behavior of enabling the internal > pulldown by default. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. It's: dt-bindings: phy: rockchi....... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 57d28c0d5696..10c05437f7ab 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt @@ -16,8 +16,8 @@ Optional properties: - drive-impedance-ohm: Specifies the drive impedance in Ohm. Possible values are 33, 40, 50, 66 and 100. If not set, the default value of 50 will be applied. - - rockchip,enable-strobe-pulldown: Enable internal pull-down for the strobe - line. If not set, pull-down is not used. + - rockchip,disable-strobe-pulldown: Disable internal pull-down for the strobe + line. If not set, pull-down is used. - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec register. If not set, the register defaults to 0x4. Maximum value 0xf.