| Message ID | 20240318144225.30835-4-brnkv.i1@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Wave515 decoder IP support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 18/03/2024 15:42, Ivan Bornyakov wrote: > Different designs may have different amount of routed reset signals. You changed nothing. This commit msg does not match code at all. I don't understand this. And your subject is entirely wrong - again, you did not drop any restriction. But in general: we expect restrictions (constraints). > Drop maxItems restriction, add a small description instead. Best regards, Krzysztof
On Mon, Mar 18, 2024 at 05:42:18PM +0300, Ivan Bornyakov wrote: > Different designs may have different amount of routed reset signals. > Drop maxItems restriction, add a small description instead. > > Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com> > --- > Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml > index 6a11c1d11fb5..2cb4f68d27ac 100644 > --- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml > +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml > @@ -34,7 +34,8 @@ properties: > maxItems: 1 > > resets: > - maxItems: 1 > + items: > + - description: Optional reset lines Your change is a NOP. In fact, the tools will translate an 'items' list with no constraints back into maxItems/minItems. So it seems whatever change you think you needed, you did not validate the change. Rob
diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml index 6a11c1d11fb5..2cb4f68d27ac 100644 --- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml @@ -34,7 +34,8 @@ properties: maxItems: 1 resets: - maxItems: 1 + items: + - description: Optional reset lines sram: $ref: /schemas/types.yaml#/definitions/phandle
Different designs may have different amount of routed reset signals. Drop maxItems restriction, add a small description instead. Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com> --- Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)