| Message ID | 20240222143911.979058-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] dt-bindings: mmc: fsl-imx-mmc: Document the required clocks | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 30 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22/02/2024 15:39, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The fsl-imx-mmc hardware needs two clocks to operate: ipg and per. > > Document these required clocks. > > This fixes the following schema warning: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, 22 Feb 2024 at 15:39, Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <festevam@denx.de> > > The fsl-imx-mmc hardware needs two clocks to operate: ipg and per. > > Document these required clocks. > > This fixes the following schema warning: > > imx27-apf27dev.dtb: mmc@10014000: Unevaluated properties are not allowed ('clock-names', 'clocks' were unexpected) > from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-mmc.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied for next, thanks! Kind regards Uffe > --- > Changes since v2: > - None. Just fixed a typo in the dt list. > > .../devicetree/bindings/mmc/fsl-imx-mmc.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml > index 221f5bc047bd..7911316fbd6a 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml > @@ -24,6 +24,14 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: ipg > + - const: per > + > interrupts: > maxItems: 1 > > @@ -34,6 +42,8 @@ properties: > const: rx-tx > > required: > + - clocks > + - clock-names > - compatible > - reg > - interrupts > @@ -46,6 +56,8 @@ examples: > compatible = "fsl,imx27-mmc", "fsl,imx21-mmc"; > reg = <0x10014000 0x1000>; > interrupts = <11>; > + clocks = <&clks 29>, <&clks 60>; > + clock-names = "ipg", "per"; > dmas = <&dma 7>; > dma-names = "rx-tx"; > bus-width = <4>; > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml index 221f5bc047bd..7911316fbd6a 100644 --- a/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-mmc.yaml @@ -24,6 +24,14 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 2 + + clock-names: + items: + - const: ipg + - const: per + interrupts: maxItems: 1 @@ -34,6 +42,8 @@ properties: const: rx-tx required: + - clocks + - clock-names - compatible - reg - interrupts @@ -46,6 +56,8 @@ examples: compatible = "fsl,imx27-mmc", "fsl,imx21-mmc"; reg = <0x10014000 0x1000>; interrupts = <11>; + clocks = <&clks 29>, <&clks 60>; + clock-names = "ipg", "per"; dmas = <&dma 7>; dma-names = "rx-tx"; bus-width = <4>;