diff mbox series

[v4,03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

Message ID 20240215123222.42609-4-tony@atomide.com
State Not Applicable
Headers show
Series Improvments for tc358775 with support for tc358765 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Tony Lindgren Feb. 15, 2024, 12:31 p.m. UTC
The tc358765 is similar to tc358775. The tc358765 just an earlier version
of the hardware, and it's pin and register compatible with tc358775 for
most part.

From the binding point of view the only difference is that the tc358765
does not have stdby-gpios.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 .../display/bridge/toshiba,tc358775.yaml         | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Feb. 15, 2024, 6:43 p.m. UTC | #1
On 15/02/2024 13:31, Tony Lindgren wrote:
> The tc358765 is similar to tc358775. The tc358765 just an earlier version
> of the hardware, and it's pin and register compatible with tc358775 for
> most part.
> 
> From the binding point of view the only difference is that the tc358765
> does not have stdby-gpios.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  .../display/bridge/toshiba,tc358775.yaml         | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
> @@ -10,7 +10,7 @@ maintainers:
>    - Vinay Simha BN <simhavcs@gmail.com>
>  
>  description: |
> -  This binding supports DSI to LVDS bridge TC358775
> +  This binding supports DSI to LVDS bridges TC358765 and TC358775
>  
>    MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane.
>    Video frame size:
> @@ -21,7 +21,9 @@ description: |
>  
>  properties:
>    compatible:
> -    const: toshiba,tc358775
> +    enum:
> +      - toshiba,tc358765
> +      - toshiba,tc358775
>  
>    reg:
>      maxItems: 1
> @@ -81,6 +83,16 @@ properties:
>        - port@0
>        - port@1
>  
> +allOf:

If there is going to be new version, please put allOf: block after
required: block.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Tony Lindgren Feb. 25, 2024, 6:11 a.m. UTC | #2
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240215 18:43]:
> If there is going to be new version, please put allOf: block after
> required: block.

OK will post v5 set.

> Anyway:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks,

Tony
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
--- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
@@ -10,7 +10,7 @@  maintainers:
   - Vinay Simha BN <simhavcs@gmail.com>
 
 description: |
-  This binding supports DSI to LVDS bridge TC358775
+  This binding supports DSI to LVDS bridges TC358765 and TC358775
 
   MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane.
   Video frame size:
@@ -21,7 +21,9 @@  description: |
 
 properties:
   compatible:
-    const: toshiba,tc358775
+    enum:
+      - toshiba,tc358765
+      - toshiba,tc358775
 
   reg:
     maxItems: 1
@@ -81,6 +83,16 @@  properties:
       - port@0
       - port@1
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: toshiba,tc358765
+    then:
+      properties:
+        stby-gpios: false
+
 required:
   - compatible
   - reg