| Message ID | 20240211095144.2589-4-tony@atomide.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Improvments for tc358775 with support for tc358765 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Sun, 11 Feb 2024 11:51:08 +0200, Tony Lindgren wrote: > The tc358765 is similar to tc358775. The tc358765 just an earlier version > of the hardware, and it's pin and register compatible with tc358775 for > most part. > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml:87:8: [error] empty value in block mapping (empty-values) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: allOf:0:if: None is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: allOf:0:then: 'anyOf' conditional failed, one must be fixed: 'stby-gpios' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: ignoring, error in schema: allOf: 0: if Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.example.dtb: /example-0/i2c@78b8000/bridge@f: failed to match any schema with compatible: ['toshiba,tc358775'] Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.example.dtb: /example-1/i2c@78b8000/bridge@f: failed to match any schema with compatible: ['toshiba,tc358775'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240211095144.2589-4-tony@atomide.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Tony, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.8-rc3 next-20240209] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/dt-bindings-display-bridge-tc358775-make-stby-gpio-optional/20240211-180213 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240211095144.2589-4-tony%40atomide.com patch subject: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20240212/202402120510.uIBwAZkI-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/r/202402120510.uIBwAZkI-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml:87:8: [error] empty value in block mapping (empty-values) -- >> Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: allOf:0:if: None is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# >> Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: allOf:0:then: 'anyOf' conditional failed, one must be fixed: 'stby-gpios' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems'] 'type' was expected from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# -- >> Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml: ignoring, error in schema: allOf: 0: if vim +87 Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml 8b0d47e879b8fe Vinay Simha BN 2020-07-10 1 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) 8b0d47e879b8fe Vinay Simha BN 2020-07-10 2 %YAML 1.2 8b0d47e879b8fe Vinay Simha BN 2020-07-10 3 --- 8b0d47e879b8fe Vinay Simha BN 2020-07-10 4 $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358775.yaml# 8b0d47e879b8fe Vinay Simha BN 2020-07-10 5 $schema: http://devicetree.org/meta-schemas/core.yaml# 8b0d47e879b8fe Vinay Simha BN 2020-07-10 6 84e85359f4999a Krzysztof Kozlowski 2022-12-16 7 title: Toshiba TC358775 DSI to LVDS bridge 8b0d47e879b8fe Vinay Simha BN 2020-07-10 8 8b0d47e879b8fe Vinay Simha BN 2020-07-10 9 maintainers: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 10 - Vinay Simha BN <simhavcs@gmail.com> 8b0d47e879b8fe Vinay Simha BN 2020-07-10 11 8b0d47e879b8fe Vinay Simha BN 2020-07-10 12 description: | 6b27cbab742a1a Tony Lindgren 2024-02-11 13 This binding supports DSI to LVDS bridges TC358765 and TC358775 8b0d47e879b8fe Vinay Simha BN 2020-07-10 14 8b0d47e879b8fe Vinay Simha BN 2020-07-10 15 MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane. 8b0d47e879b8fe Vinay Simha BN 2020-07-10 16 Video frame size: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 17 Up to 1600x1200 24-bit/pixel resolution for single-link LVDS display panel 8b0d47e879b8fe Vinay Simha BN 2020-07-10 18 limited by 135 MHz LVDS speed 8b0d47e879b8fe Vinay Simha BN 2020-07-10 19 Up to WUXGA (1920x1200 24-bit pixels) resolution for dual-link LVDS display 8b0d47e879b8fe Vinay Simha BN 2020-07-10 20 panel, limited by 270 MHz LVDS speed. 8b0d47e879b8fe Vinay Simha BN 2020-07-10 21 8b0d47e879b8fe Vinay Simha BN 2020-07-10 22 properties: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 23 compatible: 6b27cbab742a1a Tony Lindgren 2024-02-11 24 enum: 6b27cbab742a1a Tony Lindgren 2024-02-11 25 - toshiba,tc358765 6b27cbab742a1a Tony Lindgren 2024-02-11 26 - toshiba,tc358775 8b0d47e879b8fe Vinay Simha BN 2020-07-10 27 8b0d47e879b8fe Vinay Simha BN 2020-07-10 28 reg: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 29 maxItems: 1 8b0d47e879b8fe Vinay Simha BN 2020-07-10 30 description: i2c address of the bridge, 0x0f 8b0d47e879b8fe Vinay Simha BN 2020-07-10 31 8b0d47e879b8fe Vinay Simha BN 2020-07-10 32 vdd-supply: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 33 description: 1.2V LVDS Power Supply 8b0d47e879b8fe Vinay Simha BN 2020-07-10 34 8b0d47e879b8fe Vinay Simha BN 2020-07-10 35 vddio-supply: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 36 description: 1.8V IO Power Supply 8b0d47e879b8fe Vinay Simha BN 2020-07-10 37 8b0d47e879b8fe Vinay Simha BN 2020-07-10 38 stby-gpios: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 39 maxItems: 1 8b0d47e879b8fe Vinay Simha BN 2020-07-10 40 description: Standby pin, Low active 8b0d47e879b8fe Vinay Simha BN 2020-07-10 41 8b0d47e879b8fe Vinay Simha BN 2020-07-10 42 reset-gpios: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 43 maxItems: 1 8b0d47e879b8fe Vinay Simha BN 2020-07-10 44 description: Hardware reset, Low active 8b0d47e879b8fe Vinay Simha BN 2020-07-10 45 8b0d47e879b8fe Vinay Simha BN 2020-07-10 46 ports: b67554232307e7 Rob Herring 2021-01-04 47 $ref: /schemas/graph.yaml#/properties/ports 8b0d47e879b8fe Vinay Simha BN 2020-07-10 48 b67554232307e7 Rob Herring 2021-01-04 49 properties: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 50 port@0: 9a017bf40a32e5 Tony Lindgren 2024-02-11 51 $ref: /schemas/graph.yaml#/$defs/port-base 9a017bf40a32e5 Tony Lindgren 2024-02-11 52 unevaluatedProperties: false 8b0d47e879b8fe Vinay Simha BN 2020-07-10 53 description: | 8b0d47e879b8fe Vinay Simha BN 2020-07-10 54 DSI Input. The remote endpoint phandle should be a 8b0d47e879b8fe Vinay Simha BN 2020-07-10 55 reference to a valid mipi_dsi_host device node. 8b0d47e879b8fe Vinay Simha BN 2020-07-10 56 9a017bf40a32e5 Tony Lindgren 2024-02-11 57 properties: 9a017bf40a32e5 Tony Lindgren 2024-02-11 58 endpoint: 9a017bf40a32e5 Tony Lindgren 2024-02-11 59 $ref: /schemas/media/video-interfaces.yaml# 9a017bf40a32e5 Tony Lindgren 2024-02-11 60 unevaluatedProperties: false 9a017bf40a32e5 Tony Lindgren 2024-02-11 61 9a017bf40a32e5 Tony Lindgren 2024-02-11 62 properties: 9a017bf40a32e5 Tony Lindgren 2024-02-11 63 data-lanes: 9a017bf40a32e5 Tony Lindgren 2024-02-11 64 description: array of physical DSI data lane indexes. 9a017bf40a32e5 Tony Lindgren 2024-02-11 65 minItems: 1 9a017bf40a32e5 Tony Lindgren 2024-02-11 66 items: 9a017bf40a32e5 Tony Lindgren 2024-02-11 67 - const: 1 9a017bf40a32e5 Tony Lindgren 2024-02-11 68 - const: 2 9a017bf40a32e5 Tony Lindgren 2024-02-11 69 - const: 3 9a017bf40a32e5 Tony Lindgren 2024-02-11 70 - const: 4 9a017bf40a32e5 Tony Lindgren 2024-02-11 71 8b0d47e879b8fe Vinay Simha BN 2020-07-10 72 port@1: b67554232307e7 Rob Herring 2021-01-04 73 $ref: /schemas/graph.yaml#/properties/port 8b0d47e879b8fe Vinay Simha BN 2020-07-10 74 description: | 8b0d47e879b8fe Vinay Simha BN 2020-07-10 75 Video port for LVDS output (panel or connector). 8b0d47e879b8fe Vinay Simha BN 2020-07-10 76 8b0d47e879b8fe Vinay Simha BN 2020-07-10 77 port@2: b67554232307e7 Rob Herring 2021-01-04 78 $ref: /schemas/graph.yaml#/properties/port 8b0d47e879b8fe Vinay Simha BN 2020-07-10 79 description: | 8b0d47e879b8fe Vinay Simha BN 2020-07-10 80 Video port for Dual link LVDS output (panel or connector). 8b0d47e879b8fe Vinay Simha BN 2020-07-10 81 8b0d47e879b8fe Vinay Simha BN 2020-07-10 82 required: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 83 - port@0 8b0d47e879b8fe Vinay Simha BN 2020-07-10 84 - port@1 8b0d47e879b8fe Vinay Simha BN 2020-07-10 85 6b27cbab742a1a Tony Lindgren 2024-02-11 86 allOf: 6b27cbab742a1a Tony Lindgren 2024-02-11 @87 - if: 6b27cbab742a1a Tony Lindgren 2024-02-11 88 properties: 6b27cbab742a1a Tony Lindgren 2024-02-11 89 compatible: 6b27cbab742a1a Tony Lindgren 2024-02-11 90 contains: 6b27cbab742a1a Tony Lindgren 2024-02-11 91 const: toshiba,tc358765 6b27cbab742a1a Tony Lindgren 2024-02-11 92 then: 6b27cbab742a1a Tony Lindgren 2024-02-11 93 stby-gpios: false 6b27cbab742a1a Tony Lindgren 2024-02-11 94 8b0d47e879b8fe Vinay Simha BN 2020-07-10 95 required: 8b0d47e879b8fe Vinay Simha BN 2020-07-10 96 - compatible 8b0d47e879b8fe Vinay Simha BN 2020-07-10 97 - reg 8b0d47e879b8fe Vinay Simha BN 2020-07-10 98 - vdd-supply 8b0d47e879b8fe Vinay Simha BN 2020-07-10 99 - vddio-supply 8b0d47e879b8fe Vinay Simha BN 2020-07-10 100 - reset-gpios 8b0d47e879b8fe Vinay Simha BN 2020-07-10 101 - ports 8b0d47e879b8fe Vinay Simha BN 2020-07-10 102
On 11/02/2024 10:51, Tony Lindgren wrote: > The tc358765 is similar to tc358775. The tc358765 just an earlier version > of the hardware, and it's pin and register compatible with tc358775 for > most part. > > From the binding point of view the only difference is that the tc358765 > does not have stdby-gpios. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240212 08:06]: > On 11/02/2024 10:51, Tony Lindgren wrote: > > The tc358765 is similar to tc358775. The tc358765 just an earlier version > > of the hardware, and it's pin and register compatible with tc358775 for > > most part. > > > > From the binding point of view the only difference is that the tc358765 > > does not have stdby-gpios. > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. I did.. But I did not notice that this no longer works: $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml LINT Documentation/devicetree/bindings usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] yamllint: error: one of the arguments FILE_OR_DIR - is required CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json After removing the ">2&1" from the Makefile, there's some more info: yamllint: error: one of the arguments FILE_OR_DIR - is required Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs to be now run with just: $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml Regards, Tony
On 12/02/2024 09:17, Tony Lindgren wrote: > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240212 08:06]: >> On 11/02/2024 10:51, Tony Lindgren wrote: >>> The tc358765 is similar to tc358775. The tc358765 just an earlier version >>> of the hardware, and it's pin and register compatible with tc358775 for >>> most part. >>> >>> From the binding point of view the only difference is that the tc358765 >>> does not have stdby-gpios. >>> >>> Signed-off-by: Tony Lindgren <tony@atomide.com> >>> --- >> >> It does not look like you tested the bindings, at least after quick >> look. Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. > > I did.. But I did not notice that this no longer works: > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > LINT Documentation/devicetree/bindings > usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] > yamllint: error: one of the arguments FILE_OR_DIR - is required > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > After removing the ">2&1" from the Makefile, there's some more info: > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs > to be now run with just: > > $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml > Yes, since June last year. Rob later brought (in July) backwards compatible way, but apparently something changed now in Makefile. Anyway full Linux path should be considered deprecated. The same for dtbs_check. Best regards, Krzysztof
On Mon, Feb 12, 2024 at 12:30:12PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 09:17, Tony Lindgren wrote: > > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [240212 08:06]: > >> On 11/02/2024 10:51, Tony Lindgren wrote: > >>> The tc358765 is similar to tc358775. The tc358765 just an earlier version > >>> of the hardware, and it's pin and register compatible with tc358775 for > >>> most part. > >>> > >>> From the binding point of view the only difference is that the tc358765 > >>> does not have stdby-gpios. > >>> > >>> Signed-off-by: Tony Lindgren <tony@atomide.com> > >>> --- > >> > >> It does not look like you tested the bindings, at least after quick > >> look. Please run `make dt_binding_check` (see > >> Documentation/devicetree/bindings/writing-schema.rst for instructions). > >> Maybe you need to update your dtschema and yamllint. > > > > I did.. But I did not notice that this no longer works: > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > > LINT Documentation/devicetree/bindings > > usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > > After removing the ">2&1" from the Makefile, there's some more info: > > > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > > > Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs > > to be now run with just: > > > > $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml > > > > Yes, since June last year. Rob later brought (in July) backwards > compatible way, but apparently something changed now in Makefile. It broke in 6.8-rc1. I have a fix in my tree which I'll send to Linus this week. Rob
* Rob Herring <robh@kernel.org> [240212 13:51]: > On Mon, Feb 12, 2024 at 12:30:12PM +0100, Krzysztof Kozlowski wrote: > > On 12/02/2024 09:17, Tony Lindgren wrote: > > > usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] > > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > > > > After removing the ">2&1" from the Makefile, there's some more info: > > > > > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > > > > > Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs > > > to be now run with just: > > > > > > $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml > > > > > > > Yes, since June last year. Rob later brought (in July) backwards > > compatible way, but apparently something changed now in Makefile. > > It broke in 6.8-rc1. I have a fix in my tree which I'll send to Linus > this week. OK good to hear, thanks! Tony
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml @@ -10,7 +10,7 @@ maintainers: - Vinay Simha BN <simhavcs@gmail.com> description: | - This binding supports DSI to LVDS bridge TC358775 + This binding supports DSI to LVDS bridges TC358765 and TC358775 MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane. Video frame size: @@ -21,7 +21,9 @@ description: | properties: compatible: - const: toshiba,tc358775 + enum: + - toshiba,tc358765 + - toshiba,tc358775 reg: maxItems: 1 @@ -81,6 +83,15 @@ properties: - port@0 - port@1 +allOf: + - if: + properties: + compatible: + contains: + const: toshiba,tc358765 + then: + stby-gpios: false + required: - compatible - reg
The tc358765 is similar to tc358775. The tc358765 just an earlier version of the hardware, and it's pin and register compatible with tc358775 for most part. From the binding point of view the only difference is that the tc358765 does not have stdby-gpios. Signed-off-by: Tony Lindgren <tony@atomide.com> --- .../bindings/display/bridge/toshiba,tc358775.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)