| Message ID | 20240210204606.11944-2-aford173@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | soc: imx8mp: Finish support for HDMI | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi Adam, On Sat, 10 Feb 2024 14:45:57 -0600 Adam Ford <aford173@gmail.com> wrote: > From: Lucas Stach <l.stach@pengutronix.de> > > Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > Signed-off-by: Adam Ford <aford173@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I was a bit puzzled by this v4 series as it comes after v8... however thanks for keeping up! This patch is identical to the v8 I already reviewed, so: Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
On Wed, Feb 14, 2024 at 5:14 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > > Hi Adam, > > On Sat, 10 Feb 2024 14:45:57 -0600 > Adam Ford <aford173@gmail.com> wrote: > > > From: Lucas Stach <l.stach@pengutronix.de> > > > > Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I was a bit puzzled by this v4 series as it comes after v8... however > thanks for keeping up! It was confusing to me to try and figure out where the latest of each of the various components were found. I tried to explain it in the cover letter, but basically the previous V8 was due to the fact that some portion of it had been attempted 7 times. When it was brought to my attention that the PHY driver I used was not he right one and the HDMI-TX and the PVI driver were already applied, I reverted to using the revision history of the version of the PHY driver I pulled which was V3 and with my changes became V4. I debated on making this V9, but inreality this code was only attempted 3 times, and the subsequent device tree stuff had undergone some changes, but it was easier to keep them paired together with the PHY driver so the series could be applied as a whole. I will be making a V5 due to some build-bot feedback and your feedback, but I'll be sure to pull your tags when I try again. I just want to give people around a week to mull it over and test it. adam > > This patch is identical to the v8 I already reviewed, so: > > Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml new file mode 100644 index 000000000000..c43e86a8c2e0 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/fsl,imx8mp-hdmi-phy.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/fsl,imx8mp-hdmi-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX8MP HDMI PHY + +maintainers: + - Lucas Stach <l.stach@pengutronix.de> + +properties: + compatible: + enum: + - fsl,imx8mp-hdmi-phy + + reg: + maxItems: 1 + + "#clock-cells": + const: 0 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: apb + - const: ref + + "#phy-cells": + const: 0 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - "#clock-cells" + - clocks + - clock-names + - "#phy-cells" + - power-domains + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/imx8mp-clock.h> + #include <dt-bindings/power/imx8mp-power.h> + + phy@32fdff00 { + compatible = "fsl,imx8mp-hdmi-phy"; + reg = <0x32fdff00 0x100>; + clocks = <&clk IMX8MP_CLK_HDMI_APB>, + <&clk IMX8MP_CLK_HDMI_24M>; + clock-names = "apb", "ref"; + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_HDMI_TX_PHY>; + #clock-cells = <0>; + #phy-cells = <0>; + };