| Message ID | 20240209-msm8996-fix-ufs-v1-1-107b52e57420@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | scsi: ufs: qcom: fix UFSDHCD support on MSM8996 platform | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 38 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/02/2024 22:50, Dmitry Baryshkov wrote: > Describe the second RX lane used by the UFS controller on MSM8996 > platform. > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") Your commit msg does not explain why this is a fix. > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index 10c146424baa..f1de3244b473 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -43,11 +43,11 @@ properties: > > clocks: > minItems: 8 > - maxItems: 11 > + maxItems: 12 > > clock-names: > minItems: 8 > - maxItems: 11 > + maxItems: 12 Best regards, Krzysztof
On Sun, 11 Feb 2024 at 16:02, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/02/2024 22:50, Dmitry Baryshkov wrote: > > Describe the second RX lane used by the UFS controller on MSM8996 > > platform. > > > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > > Your commit msg does not explain why this is a fix. .. and it is probably unnecessary, as msm8996 has 'lanes-per-direcion = <1>;' I'll drop this for v2. > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index 10c146424baa..f1de3244b473 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -43,11 +43,11 @@ properties: > > > > clocks: > > minItems: 8 > > - maxItems: 11 > > + maxItems: 12 > > > > clock-names: > > minItems: 8 > > - maxItems: 11 > > + maxItems: 12 > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 10c146424baa..f1de3244b473 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -43,11 +43,11 @@ properties: clocks: minItems: 8 - maxItems: 11 + maxItems: 12 clock-names: minItems: 8 - maxItems: 11 + maxItems: 12 dma-coherent: true @@ -188,8 +188,8 @@ allOf: then: properties: clocks: - minItems: 11 - maxItems: 11 + minItems: 12 + maxItems: 12 clock-names: items: - const: core_clk_src @@ -203,6 +203,7 @@ allOf: - const: ref_clk - const: tx_lane0_sync_clk - const: rx_lane0_sync_clk + - const: rx_lane1_sync_clk reg: minItems: 1 maxItems: 1 @@ -257,7 +258,7 @@ allOf: maxItems: 2 clocks: minItems: 8 - maxItems: 11 + maxItems: 12 unevaluatedProperties: false
Describe the second RX lane used by the UFS controller on MSM8996 platform. Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)