| Message ID | 20240208-feature_poe-v3-16-531d2674469e@bootlin.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | net: Add support for Power over Ethernet (PoE) | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 112 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 08 Feb 2024 14:08:53 +0100, Kory Maincent wrote: > Add the TPS23881 I2C Power Sourcing Equipment controller device tree > bindings documentation. > > Sponsored-by: Dent Project <dentproject@linuxfoundation.org> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > --- > Change in v3: > - New patch. > --- > .../bindings/net/pse-pd/ti,tps2388x.yaml | 112 +++++++++++++++++++++ > 1 file changed, 112 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.example.dtb: /example-0/i2c/ethernet-pse@20: failed to match any schema with compatible: ['ti,tps2388x'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240208-feature_poe-v3-16-531d2674469e@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, 08 Feb 2024 14:08:53 +0100 Kory Maincent <kory.maincent@bootlin.com> wrote: > Add the TPS23881 I2C Power Sourcing Equipment controller device tree > bindings documentation. > > Sponsored-by: Dent Project <dentproject@linuxfoundation.org> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > --- > Change in v3: > - New patch. > --- > .../bindings/net/pse-pd/ti,tps2388x.yaml | 112 > +++++++++++++++++++++ 1 file changed, 112 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.yaml > b/Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.yaml new file mode Oops forgot to rename this binding to ti,tps23881.yaml, sorry will do in next version. Regards,
diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.yaml b/Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.yaml new file mode 100644 index 000000000000..ccd1a80befa5 --- /dev/null +++ b/Documentation/devicetree/bindings/net/pse-pd/ti,tps2388x.yaml @@ -0,0 +1,112 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/pse-pd/ti,tps2388x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI TPS2388x Power Sourcing Equipment controller + +maintainers: + - Kory Maincent <kory.maincent@bootlin.com> + +allOf: + - $ref: pse-controller.yaml# + +properties: + compatible: + enum: + - ti,tps23880 + - ti,tps23881 + + reg: + maxItems: 1 + + '#pse-cells': + const: 1 + + channels: + description: each set of 8 ports can be assigned to one physical + channels or two for PoE4. This parameter describes the configuration + of the ports conversion matrix that establishes relationship between + the logical ports and the physical channels. + type: object + + patternProperties: + '^channel@[0-7]$': + type: object + required: + - reg + +unevaluatedProperties: false + +required: + - compatible + - reg + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ethernet-pse@20 { + compatible = "ti,tps2388x"; + reg = <0x20>; + + channels { + #address-cells = <1>; + #size-cells = <0>; + + phys0: channel@0 { + reg = <0>; + }; + + phys1: channel@1 { + reg = <1>; + }; + + phys2: channel@2 { + reg = <2>; + }; + + phys3: channel@3 { + reg = <3>; + }; + + phys4: channel@4 { + reg = <4>; + }; + + phys5: channel@5 { + reg = <5>; + }; + + phys6: channel@6 { + reg = <6>; + }; + + phys7: channel@7 { + reg = <7>; + }; + }; + + pse_pis { + #address-cells = <1>; + #size-cells = <0>; + + pse_pi0: pse_pi@0 { + reg = <0>; + #pse-cells = <0>; + pairset-names = "alternative-a", "alternative-b"; + pairsets = <&phys0>, <&phys1>; + }; + + pse_pi1: pse_pi@1 { + reg = <1>; + #pse-cells = <0>; + pairset-names = "alternative-a"; + pairsets = <&phys2>; + }; + }; + }; + };
Add the TPS23881 I2C Power Sourcing Equipment controller device tree bindings documentation. Sponsored-by: Dent Project <dentproject@linuxfoundation.org> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> --- Change in v3: - New patch. --- .../bindings/net/pse-pd/ti,tps2388x.yaml | 112 +++++++++++++++++++++ 1 file changed, 112 insertions(+)