| Message ID | 20240205115721.1195336-2-quic_jingyw@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: Introduce AIM500 platform device tree | expand |
On 05/02/2024 12:57, Jingyi Wang wrote: > Document Qualcomm SM8650P SoC and AIM500 AIoT board. Please describe shortly what is SM8650P and what are the differences with SM8650. > > Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 1999a5f2f254..e87ceb42853b 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -88,11 +88,13 @@ description: | > sm8450 > sm8550 > sm8650 > + sm8650p > x1e80100 > > The 'board' element must be one of the following strings: > > adp > + aim500-aiot Drop this line. > cdp > dragonboard > idp > @@ -1051,6 +1053,13 @@ properties: > - qcom,sm8650-qrd > - const: qcom,sm8650 > > + - items: > + - enum: > + - qcom,sm8650p-aim500-aiot > + - const: qcom,sm8650p-aim500 > + - const: qcom,sm8650p > + - const: qcom,sm8650 Best regards, Krzysztof
Hi Krzysztof, On 2/5/2024 8:33 PM, Krzysztof Kozlowski wrote: > On 05/02/2024 12:57, Jingyi Wang wrote: >> Document Qualcomm SM8650P SoC and AIM500 AIoT board. > > Please describe shortly what is SM8650P and what are the differences > with SM8650. > >> >> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index 1999a5f2f254..e87ceb42853b 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -88,11 +88,13 @@ description: | >> sm8450 >> sm8550 >> sm8650 >> + sm8650p >> x1e80100 >> >> The 'board' element must be one of the following strings: >> >> adp >> + aim500-aiot > > Drop this line. > drop this line will cause fail dt binding check failure, any suggestion on that? >> cdp >> dragonboard >> idp >> @@ -1051,6 +1053,13 @@ properties: >> - qcom,sm8650-qrd >> - const: qcom,sm8650 >> >> + - items: >> + - enum: >> + - qcom,sm8650p-aim500-aiot >> + - const: qcom,sm8650p-aim500 >> + - const: qcom,sm8650p >> + - const: qcom,sm8650 > > > > Best regards, > Krzysztof > Thanks, Jingyi
On Tue, 20 Feb 2024 at 11:00, Jingyi Wang <quic_jingyw@quicinc.com> wrote: > > > Hi Krzysztof, > > On 2/5/2024 8:33 PM, Krzysztof Kozlowski wrote: > > On 05/02/2024 12:57, Jingyi Wang wrote: > >> Document Qualcomm SM8650P SoC and AIM500 AIoT board. > > > > Please describe shortly what is SM8650P and what are the differences > > with SM8650. > > > >> > >> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > >> --- > >> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > >> index 1999a5f2f254..e87ceb42853b 100644 > >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml > >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > >> @@ -88,11 +88,13 @@ description: | > >> sm8450 > >> sm8550 > >> sm8650 > >> + sm8650p > >> x1e80100 > >> > >> The 'board' element must be one of the following strings: > >> > >> adp > >> + aim500-aiot > > > > Drop this line. > > > drop this line will cause fail dt binding check failure, any suggestion on that? It will not, it is just a free-form text > >> cdp > >> dragonboard > >> idp > >> @@ -1051,6 +1053,13 @@ properties: > >> - qcom,sm8650-qrd > >> - const: qcom,sm8650 > >> > >> + - items: > >> + - enum: > >> + - qcom,sm8650p-aim500-aiot > >> + - const: qcom,sm8650p-aim500 > >> + - const: qcom,sm8650p > >> + - const: qcom,sm8650 > > > > > > > > Best regards, > > Krzysztof > > > Thanks, > Jingyi >
Hi Krzysztof & Dmitry On 2/20/2024 5:06 PM, Dmitry Baryshkov wrote: > On Tue, 20 Feb 2024 at 11:00, Jingyi Wang <quic_jingyw@quicinc.com> wrote: >> >> >> Hi Krzysztof, >> >> On 2/5/2024 8:33 PM, Krzysztof Kozlowski wrote: >>> On 05/02/2024 12:57, Jingyi Wang wrote: >>>> Document Qualcomm SM8650P SoC and AIM500 AIoT board. >>> >>> Please describe shortly what is SM8650P and what are the differences >>> with SM8650. >>> sm8650p has same base functions as sm8650 without modem-RF system. Will update the description. >>>> >>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> index 1999a5f2f254..e87ceb42853b 100644 >>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> @@ -88,11 +88,13 @@ description: | >>>> sm8450 >>>> sm8550 >>>> sm8650 >>>> + sm8650p >>>> x1e80100 >>>> >>>> The 'board' element must be one of the following strings: >>>> >>>> adp >>>> + aim500-aiot >>> >>> Drop this line. >>> >> drop this line will cause fail dt binding check failure, any suggestion on that? > > It will not, it is just a free-form text > will drop that. >>>> cdp >>>> dragonboard >>>> idp >>>> @@ -1051,6 +1053,13 @@ properties: >>>> - qcom,sm8650-qrd >>>> - const: qcom,sm8650 >>>> >>>> + - items: >>>> + - enum: >>>> + - qcom,sm8650p-aim500-aiot >>>> + - const: qcom,sm8650p-aim500 >>>> + - const: qcom,sm8650p >>>> + - const: qcom,sm8650 >>> >>> >>> >>> Best regards, >>> Krzysztof >>> >> Thanks, >> Jingyi >> > > Thanks, Jingyi
On 20/02/2024 09:55, Jingyi Wang wrote: > > Hi Krzysztof, > > On 2/5/2024 8:33 PM, Krzysztof Kozlowski wrote: >> On 05/02/2024 12:57, Jingyi Wang wrote: >>> Document Qualcomm SM8650P SoC and AIM500 AIoT board. >> >> Please describe shortly what is SM8650P and what are the differences >> with SM8650. >> >>> >>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>> index 1999a5f2f254..e87ceb42853b 100644 >>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>> @@ -88,11 +88,13 @@ description: | >>> sm8450 >>> sm8550 >>> sm8650 >>> + sm8650p >>> x1e80100 >>> >>> The 'board' element must be one of the following strings: >>> >>> adp >>> + aim500-aiot >> >> Drop this line. >> > drop this line will cause fail dt binding check failure, any suggestion on that? Really? How? Best regards, Krzysztof
Hi Krzysztof, On 2/20/2024 5:43 PM, Krzysztof Kozlowski wrote: > On 20/02/2024 09:55, Jingyi Wang wrote: >> >> Hi Krzysztof, >> >> On 2/5/2024 8:33 PM, Krzysztof Kozlowski wrote: >>> On 05/02/2024 12:57, Jingyi Wang wrote: >>>> Document Qualcomm SM8650P SoC and AIM500 AIoT board. >>> >>> Please describe shortly what is SM8650P and what are the differences >>> with SM8650. >>> >>>> >>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> index 1999a5f2f254..e87ceb42853b 100644 >>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >>>> @@ -88,11 +88,13 @@ description: | >>>> sm8450 >>>> sm8550 >>>> sm8650 >>>> + sm8650p >>>> x1e80100 >>>> >>>> The 'board' element must be one of the following strings: >>>> >>>> adp >>>> + aim500-aiot >>> >>> Drop this line. >>> >> drop this line will cause fail dt binding check failure, any suggestion on that? > > Really? How? > > > > Best regards, > Krzysztof > Sorry I made some mistakes, have just checked that remove this should be fine. Thanks, Jingyi
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 1999a5f2f254..e87ceb42853b 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -88,11 +88,13 @@ description: | sm8450 sm8550 sm8650 + sm8650p x1e80100 The 'board' element must be one of the following strings: adp + aim500-aiot cdp dragonboard idp @@ -1051,6 +1053,13 @@ properties: - qcom,sm8650-qrd - const: qcom,sm8650 + - items: + - enum: + - qcom,sm8650p-aim500-aiot + - const: qcom,sm8650p-aim500 + - const: qcom,sm8650p + - const: qcom,sm8650 + - items: - enum: - qcom,x1e80100-crd
Document Qualcomm SM8650P SoC and AIM500 AIoT board. Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)