| Message ID | 20240205-pmi632-ppg-v1-1-e236c95a2099@fairphone.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add PPG support for PMI632 LPG dtsi | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 05 Feb 2024 10:51:38 +0100, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240205-pmi632-ppg-v1-1-e236c95a2099@fairphone.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Montag, 5. Februar 2024 14:46:45 CET Rob Herring wrote: > On Mon, 05 Feb 2024 10:51:38 +0100, Luca Weiss wrote: > > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > --- > > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ > qcom,spmi-pmic.yaml: Error in referenced schema matching $id: > http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml These patches have been merged into linux-next recently, so should get into the next release. > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240205-pmi > 632-ppg-v1-1-e236c95a2099@fairphone.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your > schema.
On Mon, Feb 05, 2024 at 10:51:38AM +0100, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index 8103fb61a16c..b7f01cbb8fff 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -160,6 +160,10 @@ patternProperties: > type: object > $ref: /schemas/nvmem/qcom,spmi-sdam.yaml# > > + "^pbs@[0-9a-f]+$": > + type: object > + $ref: /schemas/soc/qcom/qcom,pbs.yaml# > + > "phy@[0-9a-f]+$": > type: object > $ref: /schemas/phy/qcom,snps-eusb2-repeater.yaml# > > -- > 2.43.0 >
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 8103fb61a16c..b7f01cbb8fff 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -160,6 +160,10 @@ patternProperties: type: object $ref: /schemas/nvmem/qcom,spmi-sdam.yaml# + "^pbs@[0-9a-f]+$": + type: object + $ref: /schemas/soc/qcom/qcom,pbs.yaml# + "phy@[0-9a-f]+$": type: object $ref: /schemas/phy/qcom,snps-eusb2-repeater.yaml#
Add the PBS (Programmable Boot Sequencer) to the list of devices. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ 1 file changed, 4 insertions(+)