| Message ID | 20240124074527.48869-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | reset: gpio: ASoC: shared GPIO resets | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Wed, Jan 24, 2024 at 08:45:22AM +0100, Krzysztof Kozlowski wrote: > Add a helper comparing two "struct of_phandle_args" to avoid > reinventing the wheel. > > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > Dependency of cpufreq and reset change. > --- > include/linux/of.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Acked-by: Rob Herring <robh@kernel.org> I've wanted to write this series for some time. Great work. Rob
On Mi, 2024-01-24 at 16:07 -0600, Rob Herring wrote: > On Wed, Jan 24, 2024 at 08:45:22AM +0100, Krzysztof Kozlowski wrote: > > Add a helper comparing two "struct of_phandle_args" to avoid > > reinventing the wheel. > > > > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > > > Dependency of cpufreq and reset change. > > --- > > include/linux/of.h | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > Acked-by: Rob Herring <robh@kernel.org> > > I've wanted to write this series for some time. Great work. How would you prefer this to be merged? Stable tag from the devicetree tree? Go through the reset tree as part of this series? regards Philipp
diff --git a/include/linux/of.h b/include/linux/of.h index 6a9ddf20e79a..85bcc05b278d 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -1065,6 +1065,22 @@ static inline int of_parse_phandle_with_optional_args(const struct device_node * 0, index, out_args); } +/** + * of_phandle_args_equal() - Compare two of_phandle_args + * @a1: First of_phandle_args to compare + * @a2: Second of_phandle_args to compare + * + * Return: True if a1 and a2 are the same (same node pointer, same phandle + * args), false otherwise. + */ +static inline bool of_phandle_args_equal(const struct of_phandle_args *a1, + const struct of_phandle_args *a2) +{ + return a1->np == a2->np && + a1->args_count == a2->args_count && + !memcmp(a1->args, a2->args, sizeof(a1->args[0]) * a1->args_count); +} + /** * of_property_count_u8_elems - Count the number of u8 elements in a property *