| Message ID | 20240122204959.1665970-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: display: nxp,tda998x: Fix 'audio-ports' constraints | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, 22 Jan 2024 14:49:58 -0600, Rob Herring wrote: > The constraints for 'audio-ports' don't match the description. There can > be 1 or 2 DAI entries and each entry is exactly 2 values. Also, the > values' sizes are 32-bits, not 8-bits. Move the size constraints to the > outer dimension (number of DAIs) and add constraints on inner array > values. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/display/bridge/nxp,tda998x.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml index 21d995f29a1e..b8e9cf6ce4e6 100644 --- a/Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml +++ b/Documentation/devicetree/bindings/display/bridge/nxp,tda998x.yaml @@ -29,19 +29,22 @@ properties: audio-ports: description: - Array of 8-bit values, 2 values per DAI (Documentation/sound/soc/dai.rst). + Array of 2 values per DAI (Documentation/sound/soc/dai.rst). The implementation allows one or two DAIs. If two DAIs are defined, they must be of different type. $ref: /schemas/types.yaml#/definitions/uint32-matrix + minItems: 1 + maxItems: 2 items: - minItems: 1 items: - description: | The first value defines the DAI type: TDA998x_SPDIF or TDA998x_I2S (see include/dt-bindings/display/tda998x.h). + enum: [ 1, 2 ] - description: The second value defines the tda998x AP_ENA reg content when the DAI in question is used. + maximum: 0xff '#sound-dai-cells': enum: [ 0, 1 ]
The constraints for 'audio-ports' don't match the description. There can be 1 or 2 DAI entries and each entry is exactly 2 values. Also, the values' sizes are 32-bits, not 8-bits. Move the size constraints to the outer dimension (number of DAIs) and add constraints on inner array values. Signed-off-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/display/bridge/nxp,tda998x.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)