| Message ID | 20240104124952.1975160-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 9 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, 04 Jan 2024 09:49:52 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The number of fsl,tmu-range entries vary among the several NXP SoCs. > > - lx2160a has two fsl,tmu-range entries (fsl,qoriq-tmu compatible) > - imx8mq has four fsl,tmu-range entries. (fsl,imx8mq-tmu compatible) > - imx93 has seven fsl,tmu-range entries. (fsl,qoriq-tmu compatible) > > Change minItems and maxItems accordingly. > > This fixes the following schema warning: > > imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed: > [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v3: > - Rebased against next-20240104. > - Do as suggested by Rob: > "So short term, I'd just leave things such that they don't warn or just > drop the conditional." > > Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Daniel, On Tue, Jan 9, 2024 at 6:29 PM Rob Herring <robh@kernel.org> wrote: > > > On Thu, 04 Jan 2024 09:49:52 -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > The number of fsl,tmu-range entries vary among the several NXP SoCs. > > > > - lx2160a has two fsl,tmu-range entries (fsl,qoriq-tmu compatible) > > - imx8mq has four fsl,tmu-range entries. (fsl,imx8mq-tmu compatible) > > - imx93 has seven fsl,tmu-range entries. (fsl,qoriq-tmu compatible) > > > > Change minItems and maxItems accordingly. > > > > This fixes the following schema warning: > > > > imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed: > > [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > --- > > Changes since v3: > > - Rebased against next-20240104. > > - Do as suggested by Rob: > > "So short term, I'd just leave things such that they don't warn or just > > drop the conditional." > > > > Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Reviewed-by: Rob Herring <robh@kernel.org> Could you please apply this one?
On 04/01/2024 13:49, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The number of fsl,tmu-range entries vary among the several NXP SoCs. > > - lx2160a has two fsl,tmu-range entries (fsl,qoriq-tmu compatible) > - imx8mq has four fsl,tmu-range entries. (fsl,imx8mq-tmu compatible) > - imx93 has seven fsl,tmu-range entries. (fsl,qoriq-tmu compatible) > > Change minItems and maxItems accordingly. > > This fixes the following schema warning: > > imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed: > [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- Applied, thanks
diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml index 145744027234..d155d6799da6 100644 --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml @@ -33,7 +33,8 @@ properties: description: | The values to be programmed into TTRnCR, as specified by the SoC reference manual. The first cell is TTR0CR, the second is TTR1CR, etc. - maxItems: 4 + minItems: 2 + maxItems: 7 fsl,tmu-calibration: $ref: /schemas/types.yaml#/definitions/uint32-matrix