| Message ID | 20231220165423.v2.3.I1016a45ac9e8daf8a9ebc9854ab90ec3542e7c30@changeid |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Improve IRQ wake capability reporting and update the cros_ec driver to use it | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 21/12/2023 00:54, Mark Hasemeyer wrote: > The wording in the current documentation is a little strong. The > intention was not to fix any particular interrupt as wakeup capable but > leave those details to the device. It wasn't intended to enforce any > rules as what can be or can't be a wakeup interrupt. > > Soften the wording to not mandate that the 'wakeup-source' property be > used, and clarify what it means when an interrupt is marked (or not > marked) for wakeup. > > Link: https://lore.kernel.org/all/ZYAjxxHcCOgDVMTQ@bogus/ > Link: https://lore.kernel.org/all/CAL_Jsq+MYwOG40X26cYmO9EkZ9xqWrXDi03MaRfxnV-+VGkXWQ@mail.gmail.com/ > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. You nicely skipped all my filters... No need to resend to fix this, but fix it if sending a new version. Best regards, Krzysztof
> Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > You nicely skipped all my filters... No need to resend to fix this, but > fix it if sending a new version. I picked up the tags by using that exact command against "wakeup-source.txt". "Documentation: devicetree:" was used in the originating commit and is why I used it. There isn't really a consistent history wrt to tags on this file. Looking at the containing directory, "dt-bindings: power" looks pretty common. I'll use that unless you'd prefer something else.
On 21/12/2023 19:16, Mark Hasemeyer wrote: >> Please use subject prefixes matching the subsystem. You can get them for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching. >> >> You nicely skipped all my filters... No need to resend to fix this, but >> fix it if sending a new version. > > I picked up the tags by using that exact command against "wakeup-source.txt". > "Documentation: devicetree:" was used in the originating commit and is > why I used it. There isn't really a consistent history wrt to tags on > this file. Looking at the containing directory, "dt-bindings: power" All bindings use dt-bindings: prefix. Either first or second. It's the only correct, even though you will find way too many wrong ones... yet still my command gives you the answer. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/wakeup-source.txt b/Documentation/devicetree/bindings/power/wakeup-source.txt index 697333a56d5e2..75bc20b95688f 100644 --- a/Documentation/devicetree/bindings/power/wakeup-source.txt +++ b/Documentation/devicetree/bindings/power/wakeup-source.txt @@ -3,16 +3,20 @@ Specifying wakeup capability for devices Any device nodes ---------------- -Nodes that describe devices which has wakeup capability must contain an +Nodes that describe devices which have wakeup capability may contain a "wakeup-source" boolean property. -Also, if device is marked as a wakeup source, then all the primary -interrupt(s) can be used as wakeup interrupt(s). +If the device is marked as a wakeup-source, interrupt wake capability depends +on the device specific "interrupt-names" property. If no interrupts are labeled +as wake capable, then it is up to the device to determine which interrupts can +wake the system. -However if the devices have dedicated interrupt as the wakeup source -then they need to specify/identify the same using device specific -interrupt name. In such cases only that interrupt can be used as wakeup -interrupt. +However if a device has a dedicated interrupt as the wakeup source, then it +needs to specify/identify it using a device specific interrupt name. In such +cases only that interrupt can be used as a wakeup interrupt. + +While various legacy interrupt names exist, new devices should use "wakeup" as +the canonical interrupt name. List of legacy properties and respective binding document ---------------------------------------------------------
The wording in the current documentation is a little strong. The intention was not to fix any particular interrupt as wakeup capable but leave those details to the device. It wasn't intended to enforce any rules as what can be or can't be a wakeup interrupt. Soften the wording to not mandate that the 'wakeup-source' property be used, and clarify what it means when an interrupt is marked (or not marked) for wakeup. Link: https://lore.kernel.org/all/ZYAjxxHcCOgDVMTQ@bogus/ Link: https://lore.kernel.org/all/CAL_Jsq+MYwOG40X26cYmO9EkZ9xqWrXDi03MaRfxnV-+VGkXWQ@mail.gmail.com/ Signed-off-by: Mark Hasemeyer <markhas@chromium.org> --- Changes in v2: -New patch .../bindings/power/wakeup-source.txt | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)