| Message ID | 20231208-dev-iio-backend-v2-1-5450951895e1@analog.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: add new backend framework | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 08/12/2023 16:14, Nuno Sa via B4 Relay wrote: > From: Nuno Sa <nuno.sa@analog.com> > > Add a new property to reference IIO backend devices. This we can see. But why? > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > index 7aa748d6b7a0..ae74249b4726 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > @@ -44,6 +44,10 @@ properties: > Pin that controls the powerdown mode of the device. > maxItems: 1 > > + io-backends: > + description: Phandle to the IIO backend device. Looks like standard property. Where is it defined? What is the meaning (your description does not tell me anything more than property name and its type) > + $ref: /schemas/types.yaml#/definitions/phandle > + Best regards, Krzysztof
On Fri, 2023-12-08 at 18:40 +0100, Krzysztof Kozlowski wrote: > On 08/12/2023 16:14, Nuno Sa via B4 Relay wrote: > > From: Nuno Sa <nuno.sa@analog.com> > > > > Add a new property to reference IIO backend devices. > > This we can see. But why? > > > > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > > --- > > Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > > b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > > index 7aa748d6b7a0..ae74249b4726 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > > @@ -44,6 +44,10 @@ properties: > > Pin that controls the powerdown mode of the device. > > maxItems: 1 > > > > + io-backends: > > + description: Phandle to the IIO backend device. > > Looks like standard property. Where is it defined? What is the meaning > (your description does not tell me anything more than property name and > its type) Yeah, Conor already gave me some feedback in the cover where I mention this property. I'll improve on the description and send a PR for a generic schema. Thanks! - Nuno Sá
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml index 7aa748d6b7a0..ae74249b4726 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml @@ -44,6 +44,10 @@ properties: Pin that controls the powerdown mode of the device. maxItems: 1 + io-backends: + description: Phandle to the IIO backend device. + $ref: /schemas/types.yaml#/definitions/phandle + reset-gpios: description: Reset pin for the device. @@ -68,6 +72,7 @@ examples: reg = <0>; clocks = <&adc_clk>; clock-names = "adc-clk"; + io-backends = <&iio_backend>; }; }; ...