diff mbox series

dt-bindings: serial: imx: Properly describe the i.MX1 interrupts

Message ID 20231206162841.2326201-1-festevam@gmail.com
State Not Applicable
Headers show
Series dt-bindings: serial: imx: Properly describe the i.MX1 interrupts | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 47 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Dec. 6, 2023, 4:28 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

i.MX1 has three UART interrupts instead of a single one like other
i.MX devices.

Take this into account for properly describing the i.MX1 UART
interrupts.

This fixes the following dt-schema warning:

imx1-ads.dtb: serial@206000: interrupts: [[30], [29], [26]] is too long
	from schema $id: http://devicetree.org/schemas/serial/fsl-imx-uart.yaml#yaml#
        
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../bindings/serial/fsl-imx-uart.yaml         | 29 +++++++++++++++----
 1 file changed, 24 insertions(+), 5 deletions(-)

Comments

Krzysztof Kozlowski Dec. 7, 2023, 8:31 a.m. UTC | #1 
On 06/12/2023 17:28, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> i.MX1 has three UART interrupts instead of a single one like other
> i.MX devices.
> 
> Take this into account for properly describing the i.MX1 UART
> interrupts.
> 
> This fixes the following dt-schema warning:
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
index 83035553044a..9c6dc16f88a6 100644
--- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
@@ -9,10 +9,6 @@  title: Freescale i.MX Universal Asynchronous Receiver/Transmitter (UART)
 maintainers:
   - Fabio Estevam <festevam@gmail.com>
 
-allOf:
-  - $ref: serial.yaml#
-  - $ref: rs485.yaml#
-
 properties:
   compatible:
     oneOf:
@@ -68,7 +64,11 @@  properties:
       - const: tx
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: UART RX Interrupt
+      - description: UART TX Interrupt
+      - description: UART RTS Interrupt
+    minItems: 1
 
   wakeup-source: true
 
@@ -110,6 +110,25 @@  required:
   - clock-names
   - interrupts
 
+allOf:
+  - $ref: serial.yaml#
+  - $ref: rs485.yaml#
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: fsl,imx1-uart
+    then:
+      properties:
+        interrupts:
+          minItems: 3
+          maxItems: 3
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+
 unevaluatedProperties: false
 
 examples: