| Message ID | 20231201160925.3136868-8-peter.griffin@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Fri, Dec 1, 2023 at 10:10 AM Peter Griffin <peter.griffin@linaro.org> wrote: > > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 > where more than one pin controller can do external wake-up interrupt. > So add a dedicated compatible for it. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > index 2bafa867aea2..de2209f8ba00 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > @@ -44,6 +44,7 @@ properties: > - const: samsung,exynos7-wakeup-eint > - items: > - enum: > + - google,gs101-wakeup-eint > - samsung,exynosautov9-wakeup-eint > - samsung,exynosautov920-wakeup-eint > - const: samsung,exynos850-wakeup-eint (to myself): I wonder why exynos850 isn't in the enum above. > @@ -111,6 +112,7 @@ allOf: > compatible: > contains: > enum: > + - google,gs101-wakeup-eint > - samsung,exynos850-wakeup-eint > then: > properties: > -- > 2.43.0.rc2.451.g8631bc7472-goog >
On 01/12/2023 17:09, Peter Griffin wrote: > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 > where more than one pin controller can do external wake-up interrupt. > So add a dedicated compatible for it. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > index 2bafa867aea2..de2209f8ba00 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > @@ -44,6 +44,7 @@ properties: > - const: samsung,exynos7-wakeup-eint > - items: > - enum: > + - google,gs101-wakeup-eint > - samsung,exynosautov9-wakeup-eint > - samsung,exynosautov920-wakeup-eint > - const: samsung,exynos850-wakeup-eint > @@ -111,6 +112,7 @@ allOf: > compatible: > contains: > enum: > + - google,gs101-wakeup-eint Drop, not needed. Best regards, Krzysztof
Hi Krzysztof, Thanks for the review. On Sun, 3 Dec 2023 at 15:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 01/12/2023 17:09, Peter Griffin wrote: > > gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 > > where more than one pin controller can do external wake-up interrupt. > > So add a dedicated compatible for it. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > index 2bafa867aea2..de2209f8ba00 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > > @@ -44,6 +44,7 @@ properties: > > - const: samsung,exynos7-wakeup-eint > > - items: > > - enum: > > + - google,gs101-wakeup-eint > > - samsung,exynosautov9-wakeup-eint > > - samsung,exynosautov920-wakeup-eint > > - const: samsung,exynos850-wakeup-eint > > @@ -111,6 +112,7 @@ allOf: > > compatible: > > contains: > > enum: > > + - google,gs101-wakeup-eint > > Drop, not needed. Will fix Peter.
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml index 2bafa867aea2..de2209f8ba00 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml @@ -44,6 +44,7 @@ properties: - const: samsung,exynos7-wakeup-eint - items: - enum: + - google,gs101-wakeup-eint - samsung,exynosautov9-wakeup-eint - samsung,exynosautov920-wakeup-eint - const: samsung,exynos850-wakeup-eint @@ -111,6 +112,7 @@ allOf: compatible: contains: enum: + - google,gs101-wakeup-eint - samsung,exynos850-wakeup-eint then: properties:
gs101 is similar to newer Exynos SoCs like Exynos850 and ExynosAutov9 where more than one pin controller can do external wake-up interrupt. So add a dedicated compatible for it. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 2 ++ 1 file changed, 2 insertions(+)