| Message ID | 20231128214816.3975893-1-robh@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: input: mediatek,pmic-keys: Drop incomplete example | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 28/11/2023 22:48, Rob Herring wrote: > The example for the Mediatek PMIC keys is incomplete as the binding is > the full PMIC, not just the sub-functions. It is preferred for MFD > examples to be complete in the top-level MFD device binding rather than > piecemeal in each sub-function binding. > > This also fixes an undocumented (by schema) compatible warning for > "mediatek,mt6397". > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Nov 28, 2023 at 03:48:16PM -0600, Rob Herring wrote: > The example for the Mediatek PMIC keys is incomplete as the binding is > the full PMIC, not just the sub-functions. It is preferred for MFD > examples to be complete in the top-level MFD device binding rather than > piecemeal in each sub-function binding. > > This also fixes an undocumented (by schema) compatible warning for > "mediatek,mt6397". > > Signed-off-by: Rob Herring <robh@kernel.org> Applied, thank you.
diff --git a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml index e34c9e78d38d..70567d92c746 100644 --- a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml +++ b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml @@ -90,26 +90,4 @@ required: unevaluatedProperties: false -examples: - - | - #include <dt-bindings/input/input.h> - #include <dt-bindings/interrupt-controller/arm-gic.h> - - pmic { - compatible = "mediatek,mt6397"; - - keys { - compatible = "mediatek,mt6397-keys"; - mediatek,long-press-mode = <1>; - power-off-time-sec = <0>; - - key-power { - linux,keycodes = <KEY_POWER>; - wakeup-source; - }; - - key-home { - linux,keycodes = <KEY_VOLUMEDOWN>; - }; - }; - }; +...
The example for the Mediatek PMIC keys is incomplete as the binding is the full PMIC, not just the sub-functions. It is preferred for MFD examples to be complete in the top-level MFD device binding rather than piecemeal in each sub-function binding. This also fixes an undocumented (by schema) compatible warning for "mediatek,mt6397". Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/input/mediatek,pmic-keys.yaml | 24 +------------------ 1 file changed, 1 insertion(+), 23 deletions(-)