| Message ID | 20231126163247.10131-1-tony@atomide.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/6] dt-bindings: tc358775: Add support for tc358765 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 26/11/2023 17:32, Tony Lindgren wrote: > The tc358765 is similar to tc358775 except for the stdby-gpios. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi,
> The tc358765 is similar to tc358775 except for the stdby-gpios.
Bad timing (for me). I'm about to send a bigger patch series for the
tc358775 which fixes the (completely) broken initialialization. And also
contains some of your fixes.
That being said, I intend to make the standby gpio optional also for the
tc358755, because it might just be hardwired on the board.
But second, I'm really curious if this bridge is working for you correctly
as it is at the moment. One particular thing I've noticed is that you must
release the reset while both the clock and the data lanes are in LP11 mode.
Otherwise, the bridge won't work properly (i.e. horizontally shifted
picture, or no picture at all).
What DSI host controller are you using?
-michael
* Michael Walle <mwalle@kernel.org> [231127 12:44]: > Hi, > > > The tc358765 is similar to tc358775 except for the stdby-gpios. > > Bad timing (for me). I'm about to send a bigger patch series for the > tc358775 which fixes the (completely) broken initialialization. And also > contains some of your fixes. OK cool, let's merge patches as needed then. Maybe ack the patches that can already be merged, and put together some merged set for the rest of the patches? Or let me know what you prefer, I'll be glad to test and tweak as needed for tc358765. > That being said, I intend to make the standby gpio optional also for the > tc358755, because it might just be hardwired on the board. OK that sounds good to me. > But second, I'm really curious if this bridge is working for you correctly > as it is at the moment. One particular thing I've noticed is that you must > release the reset while both the clock and the data lanes are in LP11 mode. > Otherwise, the bridge won't work properly (i.e. horizontally shifted > picture, or no picture at all). Yes things are working for me. But then again the bridge is initialized by the bootloader, and then Android kernel, and then I kexec to the mainline kernel. And this is with a tc358765 if that might make a difference. So I have not seen your reset issue. Andreas may be seeing it on another tc bridge variant though, so adding Andreas to the loop also. > What DSI host controller are you using? This is an old motorola mz617 tablet with a tc358765 bridge, so omapdrm. I do have one pending patch for omapdrm dsi to change the init order a bit so tc358765 probes reliably. But seems that's a separate issue from your reset issue, I'll post that to the lists too to discuss. What's the dsi host you have? Do you also have some separate i2c eeprom that's needed for initializing something or is that lcd panel specific? No idea what the eeprom is really doing here.. Regards, Tony
Hi, Am Montag, 27. November 2023, 13:44:30 CET schrieb Michael Walle: > Hi, > > > The tc358765 is similar to tc358775 except for the stdby-gpios. > > Bad timing (for me). I'm about to send a bigger patch series for the > tc358775 which fixes the (completely) broken initialialization. And also > contains some of your fixes. > > That being said, I intend to make the standby gpio optional also for the > tc358755, because it might just be hardwired on the board. > > But second, I'm really curious if this bridge is working for you correctly > as it is at the moment. One particular thing I've noticed is that you must > release the reset while both the clock and the data lanes are in LP11 mode. > Otherwise, the bridge won't work properly (i.e. horizontally shifted > picture, or no picture at all). Apparently this seems to be true for all Toshiba DSI bridges. The power on sequence for TC9595 (TC358767) also requires LP-11 before releasing the reset signal RESX. Additionally LP-11 is requires for using the DP AUX channel. This also relates to the patch set from Dmitry [1]. Best regards, Alexander [1] https://lore.kernel.org/dri-devel/20231016165355.1327217-1-dmitry.baryshkov@linaro.org/ > What DSI host controller are you using? > > -michael
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml @@ -10,7 +10,7 @@ maintainers: - Vinay Simha BN <simhavcs@gmail.com> description: | - This binding supports DSI to LVDS bridge TC358775 + This binding supports DSI to LVDS bridges TC358765 and TC358775 MIPI DSI-RX Data 4-lane, CLK 1-lane with data rates up to 800 Mbps/lane. Video frame size: @@ -21,7 +21,9 @@ description: | properties: compatible: - const: toshiba,tc358775 + enum: + - toshiba,tc358765 + - toshiba,tc358775 reg: maxItems: 1 @@ -70,12 +72,21 @@ required: - reg - vdd-supply - vddio-supply - - stby-gpios - reset-gpios - ports additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + const: toshiba,tc358775 + then: + required: + - stby-gpios + examples: - | #include <dt-bindings/gpio/gpio.h>
The tc358765 is similar to tc358775 except for the stdby-gpios. Signed-off-by: Tony Lindgren <tony@atomide.com> --- .../display/bridge/toshiba,tc358775.yaml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)