| Message ID | 20231122154238.815781-2-vigneshr@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: dma: ti: k3*: Update optional reg regions | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 22/11/2023 16:42, Vignesh Raghavendra wrote: > In preparation for introducing more register regions, add description > for existing register regions so that its easier to map reg-names to > that of SoC Documentations/TRMs. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 26 +++++++++++-------- > .../devicetree/bindings/dma/ti/k3-pktdma.yaml | 6 ++++- > .../devicetree/bindings/dma/ti/k3-udma.yaml | 5 +++- > 3 files changed, 24 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > index 4ca300a42a99..b5444800b036 100644 > --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > @@ -35,14 +35,6 @@ properties: > - ti,am64-dmss-bcdma > - ti,j721s2-dmss-bcdma-csi > > - reg: > - minItems: 3 > - maxItems: 5 > - > - reg-names: > - minItems: 3 > - maxItems: 5 Why do you remove properties from top-level? You shouldn't. We expect there to have widest constrains. This is not explained in commit msg and really not justified looking at further diff hunks. Best regards, Krzysztof
On 22/11/23 21:49, Krzysztof Kozlowski wrote: > On 22/11/2023 16:42, Vignesh Raghavendra wrote: >> In preparation for introducing more register regions, add description >> for existing register regions so that its easier to map reg-names to >> that of SoC Documentations/TRMs. >> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 26 +++++++++++-------- >> .../devicetree/bindings/dma/ti/k3-pktdma.yaml | 6 ++++- >> .../devicetree/bindings/dma/ti/k3-udma.yaml | 5 +++- >> 3 files changed, 24 insertions(+), 13 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml >> index 4ca300a42a99..b5444800b036 100644 >> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml >> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml >> @@ -35,14 +35,6 @@ properties: >> - ti,am64-dmss-bcdma >> - ti,j721s2-dmss-bcdma-csi >> >> - reg: >> - minItems: 3 >> - maxItems: 5 >> - >> - reg-names: >> - minItems: 3 >> - maxItems: 5 > > Why do you remove properties from top-level? You shouldn't. We expect > there to have widest constrains. This is not explained in commit msg and > really not justified looking at further diff hunks. > Sorry, I didn't realize having top-level constraints is a requirement and thought individual compatibles enforcing that actual constraints is sufficient. Will add these back in v3. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml index 4ca300a42a99..b5444800b036 100644 --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml @@ -35,14 +35,6 @@ properties: - ti,am64-dmss-bcdma - ti,j721s2-dmss-bcdma-csi - reg: - minItems: 3 - maxItems: 5 - - reg-names: - minItems: 3 - maxItems: 5 - "#dma-cells": const: 3 description: | @@ -141,7 +133,10 @@ allOf: ti,sci-rm-range-tchan: false reg: - maxItems: 3 + items: + - description: BCDMA Control /Status Registers region + - description: RX Channel Realtime Registers region + - description: Ring Realtime Registers region reg-names: items: @@ -160,7 +155,12 @@ allOf: then: properties: reg: - minItems: 5 + items: + - description: BCDMA Control /Status Registers region + - description: Block Copy Channel Realtime Registers region + - description: RX Channel Realtime Registers region + - description: TX Channel Realtime Registers region + - description: Ring Realtime Registers region reg-names: items: @@ -184,7 +184,11 @@ allOf: ti,sci-rm-range-bchan: false reg: - maxItems: 4 + items: + - description: BCDMA Control /Status Registers region + - description: RX Channel Realtime Registers region + - description: TX Channel Realtime Registers region + - description: Ring Realtime Registers region reg-names: items: diff --git a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml index a69f62f854d8..3580b08f65c6 100644 --- a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml +++ b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml @@ -45,7 +45,11 @@ properties: The second cell is the ASEL value for the channel reg: - maxItems: 4 + items: + - description: Packet DMA Control /Status Registers region + - description: RX Channel Realtime Registers region + - description: TX Channel Realtime Registers region + - description: Ring Realtime Registers region reg-names: items: diff --git a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml index 22f6c5e2f7f4..ded588bd079a 100644 --- a/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml +++ b/Documentation/devicetree/bindings/dma/ti/k3-udma.yaml @@ -69,7 +69,10 @@ properties: - ti,j721e-navss-mcu-udmap reg: - maxItems: 3 + items: + - description: UDMA-P Control /Status Registers region + - description: RX Channel Realtime Registers region + - description: TX Channel Realtime Registers region reg-names: items:
In preparation for introducing more register regions, add description for existing register regions so that its easier to map reg-names to that of SoC Documentations/TRMs. Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> --- .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 26 +++++++++++-------- .../devicetree/bindings/dma/ti/k3-pktdma.yaml | 6 ++++- .../devicetree/bindings/dma/ti/k3-udma.yaml | 5 +++- 3 files changed, 24 insertions(+), 13 deletions(-)