| Message ID | 20231119102638.1041978-3-enachman@marvell.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: cn913x: add COM Express boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Sun, Nov 19, 2023 at 12:26:37PM +0200, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for: > CN9130 COM Express CPU module Did you forget this one? There's only the CN9191 system here. > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..6b19f23bcf63 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,16 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus > + Armada CN9131 COM Express CPU module > + items: > + - enum: > + - marvell,ac5x-car-with-cn9131 Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't particularly helpful. Cheers, Conor. > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9131-cpu-module > + - const: marvell,cn9131 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > -- > 2.25.1 >
On Sun, 19 Nov 2023 12:26:37 +0200, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add dt bindings for: > CN9130 COM Express CPU module > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml:64:13: [warning] wrong indentation: expected 10 but found 12 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231119102638.1041978-3-enachman@marvell.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
> > + - description: > > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus > > + Armada CN9131 COM Express CPU module > > + items: > > + - enum: > > + - marvell,ac5x-car-with-cn9131 > > Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't > particularly helpful. As the description says, this is the combination of the SOM plus the carrier to give a complete RDK. Elad, do the RDK as a whole have a name? You can use that here for the compatible. Andrew
Hi Elad, kernel test robot noticed the following build warnings: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v6.7-rc2 next-20231120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Elad-Nachman/MAINTAINERS-add-ac5-to-list-of-maintained-Marvell-dts-files/20231119-182821 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20231119102638.1041978-3-enachman%40marvell.com patch subject: [PATCH v5 2/3] dt-bindings: arm64: add Marvell COM Express boards compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231120/202311201610.9d8EdO2Y-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311201610.9d8EdO2Y-lkp@intel.com/ dtcheck warnings: (new ones prefixed by >>) >> Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml:64:13: [warning] wrong indentation: expected 10 but found 12 (indentation) vim +64 Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml 8 9 maintainers: 10 - Gregory CLEMENT <gregory.clement@bootlin.com> 11 12 properties: 13 $nodename: 14 const: '/' 15 compatible: 16 oneOf: 17 18 - description: Armada 7020 SoC 19 items: 20 - const: marvell,armada7020 21 - const: marvell,armada-ap806-dual 22 - const: marvell,armada-ap806 23 24 - description: Armada 7040 SoC 25 items: 26 - const: marvell,armada7040 27 - const: marvell,armada-ap806-quad 28 - const: marvell,armada-ap806 29 30 - description: Armada 8020 SoC 31 items: 32 - const: marvell,armada8020 33 - const: marvell,armada-ap806-dual 34 - const: marvell,armada-ap806 35 36 - description: Armada 8040 SoC 37 items: 38 - const: marvell,armada8040 39 - const: marvell,armada-ap806-quad 40 - const: marvell,armada-ap806 41 42 - description: Armada CN9130 SoC with no external CP 43 items: 44 - const: marvell,cn9130 45 - const: marvell,armada-ap807-quad 46 - const: marvell,armada-ap807 47 48 - description: Armada CN9131 SoC with one external CP 49 items: 50 - const: marvell,cn9131 51 - const: marvell,cn9130 52 - const: marvell,armada-ap807-quad 53 - const: marvell,armada-ap807 54 55 - description: Armada CN9132 SoC with two external CPs 56 items: 57 - const: marvell,cn9132 58 - const: marvell,cn9131 59 - const: marvell,cn9130 60 - const: marvell,armada-ap807-quad 61 - const: marvell,armada-ap807 62 63 - description: > 64 Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus 65 Armada CN9131 COM Express CPU module 66 items: 67 - enum: 68 - marvell,ac5x-car-with-cn9131 69 - const: marvell,rd-ac5x-carrier 70 - const: marvell,cn9131-cpu-module 71 - const: marvell,cn9131 72 - const: marvell,armada-ap807-quad 73 - const: marvell,armada-ap807 74
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml index 52d78521e412..6b19f23bcf63 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml @@ -60,4 +60,16 @@ properties: - const: marvell,armada-ap807-quad - const: marvell,armada-ap807 + - description: + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus + Armada CN9131 COM Express CPU module + items: + - enum: + - marvell,ac5x-car-with-cn9131 + - const: marvell,rd-ac5x-carrier + - const: marvell,cn9131-cpu-module + - const: marvell,cn9131 + - const: marvell,armada-ap807-quad + - const: marvell,armada-ap807 + additionalProperties: true