| Message ID | 20231112184403.3449-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers… Conor. > --- > .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml > index d60626ffb28e..18bf44e06e8f 100644 > --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml > +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml > @@ -12,10 +12,11 @@ maintainers: > properties: > compatible: > enum: > - - "samsung,s5pv210-rotator" > - - "samsung,exynos4210-rotator" > - - "samsung,exynos4212-rotator" > - - "samsung,exynos5250-rotator" > + - samsung,s5pv210-rotator > + - samsung,exynos4210-rotator > + - samsung,exynos4212-rotator > + - samsung,exynos5250-rotator > + > reg: > maxItems: 1 > > -- > 2.34.1 >
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. Unfortunately yamllint skips checking these due to a bug handling bracketed lists. There's an open issue for it[1]. > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Acked-by: Rob Herring <robh@kernel.org> [1] https://github.com/adrienverge/yamllint/issues/516
On Sun, 12 Nov 2023 19:43:59 +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml index d60626ffb28e..18bf44e06e8f 100644 --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml @@ -12,10 +12,11 @@ maintainers: properties: compatible: enum: - - "samsung,s5pv210-rotator" - - "samsung,exynos4210-rotator" - - "samsung,exynos4212-rotator" - - "samsung,exynos5250-rotator" + - samsung,s5pv210-rotator + - samsung,exynos4210-rotator + - samsung,exynos4212-rotator + - samsung,exynos5250-rotator + reg: maxItems: 1
Compatibles should not use quotes in the bindings. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)