| Message ID | 20231025084614.3092295-5-o.rempel@pengutronix.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | regulator: add under-voltage support | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote: > Allow fixed-regulator to be marked as system-critical by whitelisting > the 'system-critical-regulator' property. > > This property indicating that the fixed-regulator is critical to system > stability or functionality, aligning with the recent changes in the > regulator core handling of under-voltage events for system-critical > regulators. Why would this need to be something we explicitly enable for a given regulator? Surely this is a property of the creativity of hardware engineers rather than the regulator itself. Also please avoid the use of the outdated terms whitelist and blacklist, pass and block lists are often a good alternative.
On Wed, Oct 25, 2023 at 01:41:45PM +0100, Mark Brown wrote: > On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote: > > Allow fixed-regulator to be marked as system-critical by whitelisting > > the 'system-critical-regulator' property. > > > > This property indicating that the fixed-regulator is critical to system > > stability or functionality, aligning with the recent changes in the > > regulator core handling of under-voltage events for system-critical > > regulators. > > Why would this need to be something we explicitly enable for a given > regulator? Surely this is a property of the creativity of hardware > engineers rather than the regulator itself. :) > Also please avoid the use of the outdated terms whitelist and blacklist, > pass and block lists are often a good alternative. ack
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml index ce7751b9129c..9ff9abf2691a 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml @@ -105,6 +105,8 @@ properties: description: Interrupt signaling a critical under-voltage event. + system-critical-regulator: true + required: - compatible - regulator-name
Allow fixed-regulator to be marked as system-critical by whitelisting the 'system-critical-regulator' property. This property indicating that the fixed-regulator is critical to system stability or functionality, aligning with the recent changes in the regulator core handling of under-voltage events for system-critical regulators. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/regulator/fixed-regulator.yaml | 2 ++ 1 file changed, 2 insertions(+)